chrome/browser/resources/settings/advanced_page/advanced_page.html - Issue 1372053002: Flesh out the location-page class to make it more general.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/resources/settings/advanced_page/advanced_page.html

Issue 1372053002: Flesh out the location-page class to make it more general. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Address feedback Created 5 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/extensions/api/settings_private/prefs_util.cc ('k') | chrome/browser/resources/settings/advanced_page/advanced_page.js » ('j') | chrome/browser/resources/settings/advanced_page/advanced_page.js » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/resources/settings/advanced_page/advanced_page.html

diff --git a/chrome/browser/resources/settings/advanced_page/advanced_page.html b/chrome/browser/resources/settings/advanced_page/advanced_page.html

index 871ab0a8d15f7baf7439b6cc16841b5db83404ea..4fe5e42614bd2778978681972eb04a42361985fc 100644

--- a/chrome/browser/resources/settings/advanced_page/advanced_page.html

+++ b/chrome/browser/resources/settings/advanced_page/advanced_page.html

@@ -24,7 +24,9 @@

<cr-settings-section i18n-values="page-title:siteSettingsLocation"

expand-container="{{expandContainer}}"

current-route="[[currentRoute]]" section="location">

- <cr-settings-location-page prefs="{{prefs}}">

+ <cr-settings-location-page prefs="{{prefs}}"

Dan Beam 2015/10/10 01:27:39 why would a location-page need to know that it's c

Finnur 2015/10/15 15:46:32 In email and in the CL description (a reference I'

+ category="[[contentSettingsTypes.GEOLOCATION]]"

+ categories="[[contentSettingsTypes]]">

</cr-settings-location-page>

</cr-settings-section>