Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(158)

Unified Diff: chrome/browser/resources/settings/advanced_page/advanced_page.html

Issue 1372053002: Flesh out the location-page class to make it more general. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/resources/settings/advanced_page/advanced_page.html
diff --git a/chrome/browser/resources/settings/advanced_page/advanced_page.html b/chrome/browser/resources/settings/advanced_page/advanced_page.html
index c1f1fb21904f1b1d6d784afd13beef84f7d46494..a0f438c244710b59163787fb361b6315fde29d87 100644
--- a/chrome/browser/resources/settings/advanced_page/advanced_page.html
+++ b/chrome/browser/resources/settings/advanced_page/advanced_page.html
@@ -1,10 +1,11 @@
<link rel="import" href="chrome://resources/polymer/v1_0/polymer/polymer.html">
<link rel="import" href="chrome://md-settings/downloads_page/downloads_page.html">
<link rel="import" href="chrome://md-settings/languages_page/languages_page.html">
-<link rel="import" href="chrome://md-settings/location_page/location_page.html">
<link rel="import" href="chrome://md-settings/privacy_page/privacy_page.html">
<link rel="import" href="chrome://md-settings/reset_page/reset_page.html">
<link rel="import" href="chrome://md-settings/settings_page/settings_section.html">
+<link rel="import" href="chrome://md-settings/site_settings/constants.html">
+<link rel="import" href="chrome://md-settings/site_settings/site_settings_category.html">
<if expr="chromeos">
<link rel="import" href="chrome://md-settings/a11y_page/a11y_page.html">
@@ -23,9 +24,10 @@
</if>
<settings-section i18n-values="page-title:siteSettingsLocation"
current-route="[[currentRoute]]" section="location">
- <settings-location-page prefs="{{prefs}}">
- </settings-location-page>
- </settings-section>
+ <site-settings-category id="locationCategory" prefs="{{prefs}}"
+ current-route="{{currentRoute}}">
+ </site-settings-category>
+ </cr-settings-section>
michaelpg 2015/11/02 23:25:56 wrong closing tag -- now everything is a child of
dpapad 2015/11/04 01:58:43 Good find. BTW, this broke the paper-dialog render
michaelpg 2015/11/04 02:06:11 to be fixed with https://codereview.chromium.org/1
<settings-section i18n-values="page-title:privacyPageTitle"
current-route="[[currentRoute]]" section="privacy">

Powered by Google App Engine
This is Rietveld 408576698