Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(53)

Side by Side Diff: chrome/browser/resources/settings/advanced_page/advanced_page.html

Issue 1372053002: Flesh out the location-page class to make it more general. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 <link rel="import" href="chrome://resources/polymer/v1_0/polymer/polymer.html"> 1 <link rel="import" href="chrome://resources/polymer/v1_0/polymer/polymer.html">
2 <link rel="import" href="chrome://md-settings/downloads_page/downloads_page.html "> 2 <link rel="import" href="chrome://md-settings/downloads_page/downloads_page.html ">
3 <link rel="import" href="chrome://md-settings/languages_page/languages_page.html "> 3 <link rel="import" href="chrome://md-settings/languages_page/languages_page.html ">
4 <link rel="import" href="chrome://md-settings/location_page/location_page.html">
5 <link rel="import" href="chrome://md-settings/privacy_page/privacy_page.html"> 4 <link rel="import" href="chrome://md-settings/privacy_page/privacy_page.html">
6 <link rel="import" href="chrome://md-settings/reset_page/reset_page.html"> 5 <link rel="import" href="chrome://md-settings/reset_page/reset_page.html">
7 <link rel="import" href="chrome://md-settings/settings_page/settings_section.htm l"> 6 <link rel="import" href="chrome://md-settings/settings_page/settings_section.htm l">
7 <link rel="import" href="chrome://md-settings/site_settings/constants.html">
8 <link rel="import" href="chrome://md-settings/site_settings/site_settings_catego ry.html">
8 9
9 <if expr="chromeos"> 10 <if expr="chromeos">
10 <link rel="import" href="chrome://md-settings/a11y_page/a11y_page.html"> 11 <link rel="import" href="chrome://md-settings/a11y_page/a11y_page.html">
11 <link rel="import" href="chrome://md-settings/date_time_page/date_time_page.html "> 12 <link rel="import" href="chrome://md-settings/date_time_page/date_time_page.html ">
12 </if> 13 </if>
13 14
14 <dom-module id="settings-advanced-page"> 15 <dom-module id="settings-advanced-page">
15 <link rel="import" type="css" href="advanced_page.css"> 16 <link rel="import" type="css" href="advanced_page.css">
16 <template> 17 <template>
17 <if expr="chromeos"> 18 <if expr="chromeos">
18 <settings-section i18n-values="page-title:dateTimePageTitle" 19 <settings-section i18n-values="page-title:dateTimePageTitle"
19 current-route="[[currentRoute]]" section="dateTime"> 20 current-route="[[currentRoute]]" section="dateTime">
20 <settings-date-time-page prefs="{{prefs}}"> 21 <settings-date-time-page prefs="{{prefs}}">
21 </settings-date-time-page> 22 </settings-date-time-page>
22 </settings-section> 23 </settings-section>
23 </if> 24 </if>
24 <settings-section i18n-values="page-title:siteSettingsLocation" 25 <settings-section i18n-values="page-title:siteSettingsLocation"
25 current-route="[[currentRoute]]" section="location"> 26 current-route="[[currentRoute]]" section="location">
26 <settings-location-page prefs="{{prefs}}"> 27 <site-settings-category id="locationCategory" prefs="{{prefs}}"
27 </settings-location-page> 28 current-route="{{currentRoute}}">
28 </settings-section> 29 </site-settings-category>
30 </cr-settings-section>
michaelpg 2015/11/02 23:25:56 wrong closing tag -- now everything is a child of
dpapad 2015/11/04 01:58:43 Good find. BTW, this broke the paper-dialog render
michaelpg 2015/11/04 02:06:11 to be fixed with https://codereview.chromium.org/1
29 31
30 <settings-section i18n-values="page-title:privacyPageTitle" 32 <settings-section i18n-values="page-title:privacyPageTitle"
31 current-route="[[currentRoute]]" section="privacy"> 33 current-route="[[currentRoute]]" section="privacy">
32 <settings-privacy-page prefs="{{prefs}}" 34 <settings-privacy-page prefs="{{prefs}}"
33 current-route="{{currentRoute}}"> 35 current-route="{{currentRoute}}">
34 </settings-privacy-page> 36 </settings-privacy-page>
35 </settings-section> 37 </settings-section>
36 38
37 <settings-section i18n-values="page-title:languagesPageTitle" 39 <settings-section i18n-values="page-title:languagesPageTitle"
38 current-route="[[currentRoute]]" section="languages"> 40 current-route="[[currentRoute]]" section="languages">
(...skipping 17 matching lines...) Expand all
56 <!-- TODO(dbeam): find somewhere to stuff "Add more accessibility features" 58 <!-- TODO(dbeam): find somewhere to stuff "Add more accessibility features"
57 on desktop. --> 59 on desktop. -->
58 <settings-section i18n-values="page-title:a11yPageTitle" 60 <settings-section i18n-values="page-title:a11yPageTitle"
59 current-route="[[currentRoute]]" section="a11y"> 61 current-route="[[currentRoute]]" section="a11y">
60 <settings-a11y-page prefs="{{prefs}}"></settings-a11y-page> 62 <settings-a11y-page prefs="{{prefs}}"></settings-a11y-page>
61 </settings-section> 63 </settings-section>
62 </if> 64 </if>
63 </template> 65 </template>
64 <script src="advanced_page.js"></script> 66 <script src="advanced_page.js"></script>
65 </dom-module> 67 </dom-module>
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698