Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(132)

Issue 1371983003: Revert of change pixel-serializer to support reencoding existing data (Closed)

Created:
5 years, 2 months ago by reed1
Modified:
5 years, 2 months ago
Reviewers:
msarett, scroggo
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Revert of change pixel-serializer to support reencoding existing data (patchset #5 id:80001 of https://codereview.chromium.org/1373683003/ ) Reason for revert: Need to somehow get access to encoders in chrome -- link error on the roll since SkImageEncoder is not built as part of chrome. Original issue's description: > change pixel-serializer to support reencoding existing data > > Trying to evolve this interface so it can > - support rich set of backend-encoders (including ones like ETC1 that can cheaply convert to KXT > - allow for encoding images as well as bitmaps (e.g. for picture serialization) > - perhaps replace SkImageEncoder as an API (assuming we create a factory that returns a serializer given a format) > > BUG=skia: > > Committed: https://skia.googlesource.com/skia/+/13f48dc85aa68a60da66aaf39c93d527d11d1278 TBR=scroggo@google.com,msarett@google.com NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=skia: Committed: https://skia.googlesource.com/skia/+/c9e190ddac3d193e89e580ea3819a55c28f15e61

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+66 lines, -126 lines) Patch
M gyp/core.gypi View 1 chunk +0 lines, -1 line 0 comments Download
M include/core/SkImageEncoder.h View 3 chunks +0 lines, -13 lines 0 comments Download
M include/core/SkPixelSerializer.h View 2 chunks +20 lines, -24 lines 0 comments Download
D src/core/SkPixelSerializer.cpp View 1 chunk +0 lines, -24 lines 0 comments Download
M src/core/SkWriteBuffer.cpp View 2 chunks +10 lines, -9 lines 0 comments Download
M src/image/SkImage.cpp View 3 chunks +8 lines, -14 lines 0 comments Download
M src/images/SkImageDecoder_ktx.cpp View 1 chunk +18 lines, -24 lines 0 comments Download
M src/images/SkImageEncoder.cpp View 1 chunk +0 lines, -10 lines 0 comments Download
M tests/ImageTest.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M tests/KtxTest.cpp View 2 chunks +7 lines, -5 lines 0 comments Download
M tools/sk_tool_utils.h View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
reed1
Created Revert of change pixel-serializer to support reencoding existing data
5 years, 2 months ago (2015-09-28 16:58:23 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1371983003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1371983003/1
5 years, 2 months ago (2015-09-28 16:58:34 UTC) #2
commit-bot: I haz the power
5 years, 2 months ago (2015-09-28 16:58:44 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://skia.googlesource.com/skia/+/c9e190ddac3d193e89e580ea3819a55c28f15e61

Powered by Google App Engine
This is Rietveld 408576698