Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(500)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1371913002: Material PDF: Adjust behaviour of page selector (Closed)

Created:
5 years, 2 months ago by tsergeant
Modified:
5 years, 2 months ago
Reviewers:
raymes
CC:
arv+watch_chromium.org, chrome-apps-syd-reviews_chromium.org, chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@pdf_material_rtl
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Material PDF: Prevent navigation from page selector past document bounds Previously, attempting to navigate past the bounds of the document would navigate to the first/last page of the document. This CL blocks these navigations so that no navigation is performed. BUG=535485 Committed: https://crrev.com/32749c363664e97c1f209e56234afa577a9a9b24 Cr-Commit-Position: refs/heads/master@{#351955}

Patch Set 1 #

Patch Set 2 : Block OOB navigation entirely #

Total comments: 2

Patch Set 3 : Undo change to test #

Patch Set 4 : Rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+18 lines, -11 lines) Patch
M chrome/browser/resources/pdf/elements/viewer-page-selector/viewer-page-selector.html View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/resources/pdf/elements/viewer-page-selector/viewer-page-selector.js View 1 2 3 1 chunk +11 lines, -7 lines 0 comments Download
M chrome/test/data/pdf/material_elements_test.js View 1 2 3 chunks +6 lines, -3 lines 0 comments Download

Messages

Total messages: 23 (9 generated)
tsergeant
5 years, 2 months ago (2015-09-30 02:40:50 UTC) #2
tsergeant
I've changed the behaviour as we discussed. The end result is mostly unchanged.
5 years, 2 months ago (2015-10-01 02:18:54 UTC) #3
raymes
https://codereview.chromium.org/1371913002/diff/20001/chrome/test/data/pdf/material_elements_test.js File chrome/test/data/pdf/material_elements_test.js (left): https://codereview.chromium.org/1371913002/diff/20001/chrome/test/data/pdf/material_elements_test.js#oldcode33 chrome/test/data/pdf/material_elements_test.js:33: changeInput("12pp"); How come you removed this one?
5 years, 2 months ago (2015-10-01 03:02:09 UTC) #4
tsergeant
https://codereview.chromium.org/1371913002/diff/20001/chrome/test/data/pdf/material_elements_test.js File chrome/test/data/pdf/material_elements_test.js (left): https://codereview.chromium.org/1371913002/diff/20001/chrome/test/data/pdf/material_elements_test.js#oldcode33 chrome/test/data/pdf/material_elements_test.js:33: changeInput("12pp"); On 2015/10/01 at 03:02:09, raymes wrote: > How ...
5 years, 2 months ago (2015-10-01 04:42:22 UTC) #5
raymes
lgtm
5 years, 2 months ago (2015-10-01 04:44:46 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1371913002/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1371913002/40001
5 years, 2 months ago (2015-10-01 04:50:33 UTC) #8
commit-bot: I haz the power
Try jobs failed on following builders: linux_android_rel_ng on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_android_rel_ng/builds/76255)
5 years, 2 months ago (2015-10-01 07:54:07 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1371913002/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1371913002/40001
5 years, 2 months ago (2015-10-01 07:55:05 UTC) #12
commit-bot: I haz the power
Try jobs failed on following builders: linux_android_rel_ng on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_android_rel_ng/builds/76303)
5 years, 2 months ago (2015-10-01 09:30:32 UTC) #14
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1371913002/60001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1371913002/60001
5 years, 2 months ago (2015-10-01 23:33:09 UTC) #17
commit-bot: I haz the power
Try jobs failed on following builders: linux_android_rel_ng on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_android_rel_ng/builds/76792)
5 years, 2 months ago (2015-10-02 02:34:59 UTC) #19
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1371913002/60001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1371913002/60001
5 years, 2 months ago (2015-10-02 02:41:22 UTC) #21
commit-bot: I haz the power
Committed patchset #4 (id:60001)
5 years, 2 months ago (2015-10-02 04:12:47 UTC) #22
commit-bot: I haz the power
5 years, 2 months ago (2015-10-02 04:13:40 UTC) #23
Message was sent while issue was closed. 
Patchset 4 (id:??) landed as
https://crrev.com/32749c363664e97c1f209e56234afa577a9a9b24
Cr-Commit-Position: refs/heads/master@{#351955}

Powered by Google App Engine
This is Rietveld 408576698