Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(8031)

Unified Diff: chrome/browser/resources/pdf/elements/viewer-page-selector/viewer-page-selector.js

Issue 1371913002: Material PDF: Adjust behaviour of page selector (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@pdf_material_rtl
Patch Set: Rebase Created 5 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/resources/pdf/elements/viewer-page-selector/viewer-page-selector.js
diff --git a/chrome/browser/resources/pdf/elements/viewer-page-selector/viewer-page-selector.js b/chrome/browser/resources/pdf/elements/viewer-page-selector/viewer-page-selector.js
index 8e1f2460ad34e16692dbb230dbe67a3294a73972..014362ab962c4fba693bd7e41dbbc172bda92555 100644
--- a/chrome/browser/resources/pdf/elements/viewer-page-selector/viewer-page-selector.js
+++ b/chrome/browser/resources/pdf/elements/viewer-page-selector/viewer-page-selector.js
@@ -16,22 +16,26 @@ Polymer({
},
/**
- * The current page being viewed (1-based).
+ * The current page being viewed (1-based). A change to pageNo is mirrored
+ * immediately to the input field. A change to the input field is not
+ * mirrored back until pageNoCommitted() is called and change-page is fired.
*/
pageNo: {
- type: String,
- value: '1'
+ type: Number,
+ value: 1
},
strings: Object
},
pageNoCommitted: function() {
- var page = parseInt(this.pageNo);
- if (!isNaN(page)) {
+ var page = parseInt(this.$.input.value);
+
+ if (!isNaN(page) && page <= this.docLength && page > 0)
this.fire('change-page', {page: page - 1});
- this.$.input.blur();
- }
+ else
+ this.$.input.value = this.pageNo;
+ this.$.input.blur();
},
docLengthChanged: function() {

Powered by Google App Engine
This is Rietveld 408576698