Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(149)

Issue 1371753004: ui/gfx: Make gfx::Size::GetArea use checked math. (Closed)

Created:
5 years, 2 months ago by vmpstr
Modified:
5 years, 2 months ago
CC:
chromium-reviews, cc-bugs_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

ui/gfx: Make gfx::Size::GetArea use checked math. This patch ensures that if the area calculation would overflow, we instead fail a CHECK. R=danakj, pkasting@chromium.org BUG=352761 Committed: https://crrev.com/35f226abcae1a7143e9574b31e391a8e8e0c26ae Cr-Commit-Position: refs/heads/master@{#353594}

Patch Set 1 #

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -1 line) Patch
M ui/gfx/geometry/size.h View 1 1 chunk +1 line, -0 lines 0 comments Download
M ui/gfx/geometry/size.cc View 2 chunks +4 lines, -1 line 0 comments Download

Messages

Total messages: 10 (2 generated)
vmpstr
Please take a look.
5 years, 2 months ago (2015-09-25 22:34:13 UTC) #1
vmpstr
On 2015/09/25 22:34:13, vmpstr wrote: > Please take a look. ash/display has a few instances ...
5 years, 2 months ago (2015-09-25 22:38:48 UTC) #2
Peter Kasting
LGTM. This checked math should be very cheap, so I'm not worried about perf impact. ...
5 years, 2 months ago (2015-09-25 23:03:02 UTC) #3
vmpstr
danakj@, vollick@, can you take a look please?
5 years, 2 months ago (2015-10-02 18:11:59 UTC) #5
danakj
LGTM
5 years, 2 months ago (2015-10-06 20:27:57 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1371753004/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1371753004/20001
5 years, 2 months ago (2015-10-12 21:00:23 UTC) #8
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 2 months ago (2015-10-12 21:08:29 UTC) #9
commit-bot: I haz the power
5 years, 2 months ago (2015-10-12 21:08:55 UTC) #10
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/35f226abcae1a7143e9574b31e391a8e8e0c26ae
Cr-Commit-Position: refs/heads/master@{#353594}

Powered by Google App Engine
This is Rietveld 408576698