ui/gfx/geometry/size.h - Issue 1371753004: ui/gfx: Make gfx::Size::GetArea use checked math.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: ui/gfx/geometry/size.h

Issue 1371753004: ui/gfx: Make gfx::Size::GetArea use checked math. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 5 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: ui/gfx/geometry/size.h

diff --git a/ui/gfx/geometry/size.h b/ui/gfx/geometry/size.h

index 754978672e9054cf482f078872f62fd1bf697aae..27face1d9c7ce4e5840715eff0b92794763f2938 100644

--- a/ui/gfx/geometry/size.h

+++ b/ui/gfx/geometry/size.h

@@ -47,6 +47,7 @@ class GFX_EXPORT Size {

void set_width(int width) { width_ = width < 0 ? 0 : width; }

void set_height(int height) { height_ = height < 0 ? 0 : height; }

+ // This call will CHECK if the area of this size would overflow int.

int GetArea() const;

void SetSize(int width, int height) {

« no previous file with comments | « no previous file | ui/gfx/geometry/size.cc » ('j') | no next file with comments »