Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(121)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1371713002: [Autofill] Return early when no new forms are parsed. (Closed)

Created:
5 years, 2 months ago by Mathieu
Modified:
5 years, 2 months ago
Reviewers:
Evan Stade
CC:
chromium-reviews, rouslan+autofill_chromium.org, bondd+autofillwatch_chromium.org, jdonnelly+autofillwatch_chromium.org, browser-components-watch_chromium.org, estade+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[Autofill] Return early when no new forms are parsed. Per bug, we would send duplicate queries upon parsing previously-known forms on a page. BUG=512173 Committed: https://crrev.com/cbf10aec48ae6646f9bcd940b314abadd7bcbd78 Cr-Commit-Position: refs/heads/master@{#351161}

Patch Set 1 : initial #

Total comments: 4

Patch Set 2 : addressed comments #

Unified diffs Side-by-side diffs Delta from patch set Stats (+24 lines, -0 lines) Patch
M components/autofill/core/browser/autofill_manager.cc View 1 1 chunk +3 lines, -0 lines 0 comments Download
M components/autofill/core/browser/autofill_manager_unittest.cc View 2 chunks +21 lines, -0 lines 0 comments Download

Messages

Total messages: 11 (4 generated)
Mathieu
Hi Evan, This is option (2) from crbug.com/512173.
5 years, 2 months ago (2015-09-25 18:54:30 UTC) #2
Evan Stade
https://codereview.chromium.org/1371713002/diff/40001/components/autofill/core/browser/autofill_download_manager.cc File components/autofill/core/browser/autofill_download_manager.cc (right): https://codereview.chromium.org/1371713002/diff/40001/components/autofill/core/browser/autofill_download_manager.cc#newcode111 components/autofill/core/browser/autofill_download_manager.cc:111: LOG(ERROR) << form_xml; i assume you added this for ...
5 years, 2 months ago (2015-09-26 00:09:16 UTC) #5
Mathieu
Thanks, have a look https://codereview.chromium.org/1371713002/diff/40001/components/autofill/core/browser/autofill_download_manager.cc File components/autofill/core/browser/autofill_download_manager.cc (right): https://codereview.chromium.org/1371713002/diff/40001/components/autofill/core/browser/autofill_download_manager.cc#newcode111 components/autofill/core/browser/autofill_download_manager.cc:111: LOG(ERROR) << form_xml; On 2015/09/26 ...
5 years, 2 months ago (2015-09-26 14:12:58 UTC) #6
Evan Stade
lgtm
5 years, 2 months ago (2015-09-28 16:34:03 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1371713002/60001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1371713002/60001
5 years, 2 months ago (2015-09-28 16:46:15 UTC) #9
commit-bot: I haz the power
Committed patchset #2 (id:60001)
5 years, 2 months ago (2015-09-28 21:20:08 UTC) #10
commit-bot: I haz the power
5 years, 2 months ago (2015-09-28 21:21:24 UTC) #11
Message was sent while issue was closed. 
Patchset 2 (id:??) landed as
https://crrev.com/cbf10aec48ae6646f9bcd940b314abadd7bcbd78
Cr-Commit-Position: refs/heads/master@{#351161}

Powered by Google App Engine
This is Rietveld 408576698