Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(86)

Side by Side Diff: components/autofill/core/browser/autofill_download_manager.cc

Issue 1371713002: [Autofill] Return early when no new forms are parsed. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: initial Created 5 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2014 The Chromium Authors. All rights reserved. 1 // Copyright 2014 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "components/autofill/core/browser/autofill_download_manager.h" 5 #include "components/autofill/core/browser/autofill_download_manager.h"
6 6
7 #include "base/logging.h" 7 #include "base/logging.h"
8 #include "base/prefs/pref_service.h" 8 #include "base/prefs/pref_service.h"
9 #include "base/rand_util.h" 9 #include "base/rand_util.h"
10 #include "base/stl_util.h" 10 #include "base/stl_util.h"
(...skipping 90 matching lines...) Expand 10 before | Expand all | Expand 10 after
101 101
102 std::string query_data; 102 std::string query_data;
103 if (CheckCacheForQueryRequest(request_data.form_signatures, &query_data)) { 103 if (CheckCacheForQueryRequest(request_data.form_signatures, &query_data)) {
104 VLOG(1) << "AutofillDownloadManager: query request has been retrieved " 104 VLOG(1) << "AutofillDownloadManager: query request has been retrieved "
105 << "from the cache, form signatures: " 105 << "from the cache, form signatures: "
106 << GetCombinedSignature(request_data.form_signatures); 106 << GetCombinedSignature(request_data.form_signatures);
107 observer_->OnLoadedServerPredictions(query_data); 107 observer_->OnLoadedServerPredictions(query_data);
108 return true; 108 return true;
109 } 109 }
110 110
111 LOG(ERROR) << form_xml;
Evan Stade 2015/09/26 00:09:16 i assume you added this for debugging. Remove?
Mathieu 2015/09/26 14:12:58 Thanks!
111 return StartRequest(form_xml, request_data); 112 return StartRequest(form_xml, request_data);
112 } 113 }
113 114
114 bool AutofillDownloadManager::StartUploadRequest( 115 bool AutofillDownloadManager::StartUploadRequest(
115 const FormStructure& form, 116 const FormStructure& form,
116 bool form_was_autofilled, 117 bool form_was_autofilled,
117 const ServerFieldTypeSet& available_field_types, 118 const ServerFieldTypeSet& available_field_types,
118 const std::string& login_form_signature) { 119 const std::string& login_form_signature) {
119 std::string form_xml; 120 std::string form_xml;
120 if (!form.EncodeUploadRequest(available_field_types, form_was_autofilled, 121 if (!form.EncodeUploadRequest(available_field_types, form_was_autofilled,
(...skipping 210 matching lines...) Expand 10 before | Expand all | Expand 10 after
331 } 332 }
332 333
333 observer_->OnUploadedPossibleFieldTypes(); 334 observer_->OnUploadedPossibleFieldTypes();
334 } 335 }
335 } 336 }
336 delete it->first; 337 delete it->first;
337 url_fetchers_.erase(it); 338 url_fetchers_.erase(it);
338 } 339 }
339 340
340 } // namespace autofill 341 } // namespace autofill
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698