components/autofill/content/renderer/password_autofill_agent.h - Issue 1371673002: Remove a bunch of provisionalDataSource() usage.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/autofill/content/renderer/password_autofill_agent.h

Issue 1371673002: Remove a bunch of provisionalDataSource() usage. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 5 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: components/autofill/content/renderer/password_autofill_agent.h

diff --git a/components/autofill/content/renderer/password_autofill_agent.h b/components/autofill/content/renderer/password_autofill_agent.h

index 33dba50b189e6b984f1569d7658962c01a86d02c..f934d071c412cea259a6af0c8a1429fb802aaa52 100644

--- a/components/autofill/content/renderer/password_autofill_agent.h

+++ b/components/autofill/content/renderer/password_autofill_agent.h

@@ -152,7 +152,6 @@ class PasswordAutofillAgent : public content::RenderFrameObserver {

void OnDestruct() override;

void DidStartLoading() override;

void DidStopLoading() override;

- void DidStartProvisionalLoad(blink::WebLocalFrame* frame) override;

private:

PasswordAutofillAgent* agent_;

@@ -167,6 +166,7 @@ class PasswordAutofillAgent : public content::RenderFrameObserver {

void DidFinishLoad() override;

void FrameDetached() override;

void FrameWillClose() override;

+ void DidStartProvisionalLoad(blink::WebDataSource* datasource) override;

void DidCommitProvisionalLoad(bool is_new_navigation,

bool is_same_page_navigation) override;

void WillSendSubmitEvent(const blink::WebFormElement& form) override;

@@ -175,7 +175,6 @@ class PasswordAutofillAgent : public content::RenderFrameObserver {

// Legacy RenderViewObserver:

void DidStartLoading();

void DidStopLoading();

- void LegacyDidStartProvisionalLoad(blink::WebLocalFrame* frame);

// RenderView IPC handlers:

void OnFillPasswordForm(int key, const PasswordFormFillData& form_data);