Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(85)

Unified Diff: components/autofill/content/renderer/password_autofill_agent.cc

Issue 1371673002: Remove a bunch of provisionalDataSource() usage. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/autofill/content/renderer/password_autofill_agent.cc
diff --git a/components/autofill/content/renderer/password_autofill_agent.cc b/components/autofill/content/renderer/password_autofill_agent.cc
index 9e6df579fc42a7de38533b88c3a43d51f1cad37a..89d2fac032cf7518c42e5923d2d570ae6b07669e 100644
--- a/components/autofill/content/renderer/password_autofill_agent.cc
+++ b/components/autofill/content/renderer/password_autofill_agent.cc
@@ -1232,15 +1232,15 @@ void PasswordAutofillAgent::WillSubmitForm(const blink::WebFormElement& form) {
}
}
-void PasswordAutofillAgent::LegacyDidStartProvisionalLoad(
- blink::WebLocalFrame* navigated_frame) {
+void PasswordAutofillAgent::DidStartProvisionalLoad(
+ blink::WebDataSource* datasource) {
scoped_ptr<RendererSavePasswordProgressLogger> logger;
if (logging_state_active_) {
logger.reset(new RendererSavePasswordProgressLogger(this, routing_id()));
logger->LogMessage(Logger::STRING_DID_START_PROVISIONAL_LOAD_METHOD);
}
- if (navigated_frame->parent()) {
+ if (render_frame()->GetWebFrame()->parent()) {
if (logger)
logger->LogMessage(Logger::STRING_FRAME_NOT_MAIN_FRAME);
return;
@@ -1250,8 +1250,7 @@ void PasswordAutofillAgent::LegacyDidStartProvisionalLoad(
// the user is performing actions outside the page (e.g. typed url,
// history navigation). We don't want to trigger saving in these cases.
content::DocumentState* document_state =
- content::DocumentState::FromDataSource(
- navigated_frame->provisionalDataSource());
+ content::DocumentState::FromDataSource(datasource);
content::NavigationState* navigation_state =
document_state->navigation_state();
ui::PageTransition type = navigation_state->GetTransitionType();
@@ -1569,9 +1568,4 @@ void PasswordAutofillAgent::LegacyPasswordAutofillAgent::DidStopLoading() {
agent_->DidStopLoading();
}
-void PasswordAutofillAgent::LegacyPasswordAutofillAgent::
- DidStartProvisionalLoad(blink::WebLocalFrame* navigated_frame) {
- agent_->LegacyDidStartProvisionalLoad(navigated_frame);
-}
-
} // namespace autofill

Powered by Google App Engine
This is Rietveld 408576698