Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(52)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 137143002: Remove compile time flag ORIENTATION_EVENT and use runtime flag instead. Update layout test case to… (Closed)

Created:
6 years, 11 months ago by maheshkk
Modified:
6 years, 11 months ago
Reviewers:
abarth-chromium
CC:
blink-reviews, adamk+blink_chromium.org, dglazkov+blink, arv+blink, Inactive, watchdog-blink-watchlist_google.com
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Visibility:
Public.

Description

Remove compile time flag ORIENTATION_EVENT and use runtime flag instead. Update layout test case to use runtime flag. Depends on 131913003 & 132203007 BUG=181136, 331337 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=165042

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+31 lines, -47 lines) Patch
LayoutTests/fast/dom/Orientation/create-event-orientationchange-expected.txt View 2 chunks +2 lines, -2 lines 0 comments Download
LayoutTests/fast/dom/Orientation/script-tests/create-event-orientationchange.js View 1 chunk +13 lines, -9 lines 0 comments Download
Source/build/features.gypi View 2 chunks +0 lines, -2 lines 0 comments Download
Source/core/events/EventAliases.in View 1 chunk +1 line, -1 line 0 comments Download
Source/core/frame/DOMWindow.h View 1 chunk +0 lines, -3 lines 0 comments Download
Source/core/frame/DOMWindow.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
Source/core/frame/Frame.h View 2 chunks +0 lines, -4 lines 0 comments Download
Source/core/frame/Frame.cpp View 2 chunks +3 lines, -4 lines 0 comments Download
Source/core/frame/Window.idl View 2 chunks +2 lines, -2 lines 0 comments Download
Source/core/html/HTMLBodyElement.h View 1 chunk +0 lines, -3 lines 0 comments Download
Source/core/html/HTMLBodyElement.cpp View 1 chunk +1 line, -3 lines 0 comments Download
Source/core/html/HTMLBodyElement.idl View 1 chunk +1 line, -1 line 0 comments Download
Source/core/html/HTMLFrameSetElement.h View 1 chunk +0 lines, -3 lines 0 comments Download
Source/core/html/HTMLFrameSetElement.cpp View 1 chunk +1 line, -3 lines 0 comments Download
Source/core/html/HTMLFrameSetElement.idl View 1 chunk +1 line, -1 line 0 comments Download
Source/web/TextFinder.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
Source/web/WebFrameImpl.cpp View 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
maheshkk
1. Added dummy runtime flag CL committed @ 132203007 2. Enable runtime flag only for ...
6 years, 11 months ago (2014-01-13 18:49:59 UTC) #1
abarth-chromium
lgtm
6 years, 11 months ago (2014-01-14 04:02:25 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/mahesh.kk@samsung.com/137143002/1
6 years, 11 months ago (2014-01-14 04:07:31 UTC) #3
commit-bot: I haz the power
6 years, 11 months ago (2014-01-14 08:21:31 UTC) #4
Message was sent while issue was closed. 
Change committed as 165042

Powered by Google App Engine
This is Rietveld 408576698