Source/core/html/HTMLBodyElement.cpp - Issue 137143002: Remove compile time flag ORIENTATION_EVENT and use runtime flag instead. Update layout test case to…

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/html/HTMLBodyElement.cpp

Issue 137143002: Remove compile time flag ORIENTATION_EVENT and use runtime flag instead. Update layout test case to… (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Created 6 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: Source/core/html/HTMLBodyElement.cpp

diff --git a/Source/core/html/HTMLBodyElement.cpp b/Source/core/html/HTMLBodyElement.cpp

index 1cace815aae43da470af905982881d26c02aff0e..8c7b52c1a6e728f4af668f41aac51283bab893da 100644

--- a/Source/core/html/HTMLBodyElement.cpp

+++ b/Source/core/html/HTMLBodyElement.cpp

@@ -130,10 +130,8 @@ void HTMLBodyElement::parseAttribute(const QualifiedName& name, const AtomicStri

document().setWindowAttributeEventListener(EventTypeNames::error, createAttributeEventListener(document().frame(), name, value));

else if (name == onfocusAttr)

document().setWindowAttributeEventListener(EventTypeNames::focus, createAttributeEventListener(document().frame(), name, value));

-#if ENABLE(ORIENTATION_EVENTS)

- else if (name == onorientationchangeAttr)

+ else if (RuntimeEnabledFeatures::orientationEventEnabled() && name == onorientationchangeAttr)

document().setWindowAttributeEventListener(EventTypeNames::orientationchange, createAttributeEventListener(document().frame(), name, value));

-#endif

else if (name == onhashchangeAttr)

document().setWindowAttributeEventListener(EventTypeNames::hashchange, createAttributeEventListener(document().frame(), name, value));

else if (name == onmessageAttr)

« no previous file with comments | « Source/core/html/HTMLBodyElement.h ('k') | Source/core/html/HTMLBodyElement.idl » ('j') | no next file with comments »