trunk/src/chrome/browser/chromeos/login/parallel_authenticator_unittest.cc - Issue 137133007: Revert 246674 "Indicate which authentication flow was used in Us..."

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: trunk/src/chrome/browser/chromeos/login/parallel_authenticator_unittest.cc

Issue 137133007: Revert 246674 "Indicate which authentication flow was used in Us..." (Closed) Base URL: svn://svn.chromium.org/chrome/

Patch Set: Created 6 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « trunk/src/chrome/browser/chromeos/login/parallel_authenticator.cc ('k') | trunk/src/chrome/browser/chromeos/login/screen_locker.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: trunk/src/chrome/browser/chromeos/login/parallel_authenticator_unittest.cc

===================================================================

--- trunk/src/chrome/browser/chromeos/login/parallel_authenticator_unittest.cc (revision 246711)

+++ trunk/src/chrome/browser/chromeos/login/parallel_authenticator_unittest.cc (working copy)

@@ -146,13 +146,11 @@

const std::string& password,

const std::string& username_hash_,

bool pending) {

- EXPECT_CALL(consumer_, OnLoginSuccess(UserContext(

- username,

- password,

- std::string(),

- username_hash_,

- true, // using_oauth

- UserContext::AUTH_FLOW_OFFLINE)))

+ EXPECT_CALL(consumer_, OnLoginSuccess(UserContext(username,

+ password,

+ std::string(),

+ username_hash_,

+ true /* using_oauth */)))

.WillOnce(Invoke(MockConsumer::OnSuccessQuit))

.RetiresOnSaturation();

}

@@ -209,13 +207,11 @@

};

TEST_F(ParallelAuthenticatorTest, OnLoginSuccess) {

- EXPECT_CALL(consumer_, OnLoginSuccess(UserContext(

- username_,

- password_,

- std::string(),

- username_hash_,

- true, // using oauth

- UserContext::AUTH_FLOW_OFFLINE)))

+ EXPECT_CALL(consumer_, OnLoginSuccess(UserContext(username_,

+ password_,

+ std::string(),

+ username_hash_,

+ true /* using oauth */)))

.Times(1)

.RetiresOnSaturation();