Escape "--" in the page URL at page serialization

Escape "--" in the page URL at page serialization

This patch makes page serializer to escape the page URL embed into a HTML
comment of result HTML[1] to avoid inserting text as HTML from URL by
introducing a static member function |PageSerialzier::markOfTheWebDeclaration()|
for sharing it between |PageSerialzier| and |WebPageSerialzier| classes.

[1] We use following format for serialized HTML:
saved from url=(${lengthOfURL})${URL}

BUG=503217
TEST=webkit_unit_tests --gtest_filter=PageSerializerTest.markOfTheWebDeclaration
TEST=webkit_unit_tests --gtest_filter=WebPageSerializerTest.fromUrlWithMinusMinu

Committed: https://crrev.com/a81593e7f162428585832ac8f6e71f75592b53e7
Cr-Commit-Position: refs/heads/master@{#351736}

[yosin_UTC9, 2015-09-30 08:52:08]

yosin@chromium.org changed reviewers:
+ tkent@chromium.org

[yosin_UTC9, 2015-09-30 08:52:28]

PTAL

[tkent, 2015-09-30 09:01:46]

https://codereview.chromium.org/1371323003/diff/1/third_party/WebKit/Source/c...
File third_party/WebKit/Source/core/page/PageSerializer.cpp (right):

https://codereview.chromium.org/1371323003/diff/1/third_party/WebKit/Source/c...
third_party/WebKit/Source/core/page/PageSerializer.cpp:594: builder.append(ch);
This line adds a part of UTF8-encoded Unicode character as a single character.
This doesn't work for non-ASCII characters.
Can |url| contain non-ASCII characters?

[yosin_UTC9, 2015-09-30 10:15:00]

PTAL

https://codereview.chromium.org/1371323003/diff/1/third_party/WebKit/Source/c...
File third_party/WebKit/Source/core/page/PageSerializer.cpp (right):

https://codereview.chromium.org/1371323003/diff/1/third_party/WebKit/Source/c...
third_party/WebKit/Source/core/page/PageSerializer.cpp:594: builder.append(ch);
On 2015/09/30 09:01:46, tkent wrote:
> This line adds a part of UTF8-encoded Unicode character as a single character.
> This doesn't work for non-ASCII characters.
> Can |url| contain non-ASCII characters?
> 

No. |url| should be ASCII characters.
I changed |utf8()| to |ascii()|.

https://codereview.chromium.org/1371323003/diff/1/third_party/WebKit/Source/c...
third_party/WebKit/Source/core/page/PageSerializer.cpp:597: return
String::format("saved from url=(%04zu)%s", escapedUrl.length(),
escapedUrl.data());
It seems Windows doesn't like %04zu. I'll use %04d as original code.

[tkent, 2015-10-01 01:58:30]

lgtm

[yosin_UTC9, 2015-10-01 05:51:33]

The CQ bit was checked by yosin@chromium.org

[commit-bot: I haz the power, 2015-10-01 05:52:02]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1371323003/10007
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1371323003/10007

[commit-bot: I haz the power, 2015-10-01 05:57:42]

Committed patchset #2 (id:10007)

[commit-bot: I haz the power, 2015-10-01 05:59:31]

Patchset 2 (id:??) landed as
https://crrev.com/a81593e7f162428585832ac8f6e71f75592b53e7
Cr-Commit-Position: refs/heads/master@{#351736}