Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1428)

Unified Diff: Source/web/tests/data/touch-action-simple.html

Issue 137123009: Add hittest mode for Touch-action which ignore inline elements and svg elements (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: incoporated review comments Created 6 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: Source/web/tests/data/touch-action-simple.html
diff --git a/Source/web/tests/data/touch-action-simple.html b/Source/web/tests/data/touch-action-simple.html
index 6219b147008ad7de17dff79be53457787c23a809..544fffa494292dd283450d9b790df95ae68d5d3c 100644
--- a/Source/web/tests/data/touch-action-simple.html
+++ b/Source/web/tests/data/touch-action-simple.html
@@ -21,15 +21,31 @@
</div>
</div>
+<div class='ta-none' style='height: 0; margin-bottom: 50px'>
+ <span expected-action='none' style='display:inline-block'>
+ touch-action should be inherited by inline-block elements
+ </span>
+</div>
+
+<div class='ta-none' style='height: 0; margin-bottom: 50px'>
+ <span expected-action='none' style='display:table-cell'>
+ touch-action should be inherited by table-cell elements
+ </span>
+</div>
+
<div style='padding: 20px 0'>
<span class='ta-none' expected-action='auto'>Touch-action should be ignored on inline elements
<div expected-action='auto'>And not propagated to any block children</div>
</span>
</div>
-<p>Below case is broken, should be AUTO - <a href='http://crbug.com/319479'>Bug 319479</a></p>
+
<div class='ta-none' style='height: 0; margin-bottom: 100px'>
- <span expected-action='none'>
+ <span expected-action='auto'>
touch-action should not be inherited by inline elements
<div expected-action='none'>But is inherited by any block descendants of them</div>
</span>
</div>
+
+<svg class='ta-none' xmlns="http://www.w3.org/2000/svg">
+<circle expected-action='auto' r="50"/>
+</svg>
gnana 2014/02/24 18:59:50 while running unit test, it crashes for SVG while
Rick Byers 2014/02/25 22:52:03 Oh, looks like I should have had an ASSERT_GT inst
gnana 2014/02/27 13:26:59 Added test for svg root alone. Done.
« Source/web/tests/TouchActionTest.cpp ('K') | « Source/web/tests/TouchActionTest.cpp ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698