Source/web/tests/data/touch-action-simple.html - Issue 137123009: Add hittest mode for Touch-action which ignore inline elements and svg elements

Side by Side Diff: Source/web/tests/data/touch-action-simple.html

Issue 137123009: Add hittest mode for Touch-action which ignore inline elements and svg elements (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: incoporated review comments Created 6 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

OLD	NEW
1 <!DOCTYPE html>	1 <!DOCTYPE html>

2 <link rel='stylesheet' type='text/css' href='touch-action-tests.css'>	2 <link rel='stylesheet' type='text/css' href='touch-action-tests.css'>

3 <script src='touch-action-tests.js'></script>	3 <script src='touch-action-tests.js'></script>

4	4

5 <!--	5 <!--

6 Test a bunch of simple cases where touch-action: none results in a non-fast -scrollable region.	6 Test a bunch of simple cases where touch-action: none results in a non-fast -scrollable region.

7 -->	7 -->

8	8

9 <div expected-action='auto'>Simple div with no explicit touch-action</div>	9 <div expected-action='auto'>Simple div with no explicit touch-action</div>

10 <div class='ta-none' expected-action='none'>Simple div with touch-action: none</ div>	10 <div class='ta-none' expected-action='none'>Simple div with touch-action: none</ div>

11	11

12 <div class='ta-none' style='height: 0; margin-bottom: 50px'>	12 <div class='ta-none' style='height: 0; margin-bottom: 50px'>

13 <div expected-action='none'>	13 <div expected-action='none'>

14 Touch-action: none is propagated to descendants	14 Touch-action: none is propagated to descendants

15 </div>	15 </div>

16 </div>	16 </div>

17	17

18 <div class='ta-none' style='height: 0; margin-bottom: 50px'>	18 <div class='ta-none' style='height: 0; margin-bottom: 50px'>

19 <div class='ta-auto' expected-action='none'>	19 <div class='ta-auto' expected-action='none'>

20 Explicitly setting touch-action: auto does nothing to prevent propagation of none	20 Explicitly setting touch-action: auto does nothing to prevent propagation of none

21 </div>	21 </div>

22 </div>	22 </div>

23	23

	24 <div class='ta-none' style='height: 0; margin-bottom: 50px'>

	25 <span expected-action='none' style='display:inline-block'>

	26 touch-action should be inherited by inline-block elements

	27 </span>

	28 </div>

	29

	30 <div class='ta-none' style='height: 0; margin-bottom: 50px'>

	31 <span expected-action='none' style='display:table-cell'>

	32 touch-action should be inherited by table-cell elements

	33 </span>

	34 </div>

	35

24 <div style='padding: 20px 0'>	36 <div style='padding: 20px 0'>

25 <span class='ta-none' expected-action='auto'>Touch-action should be ignored on inline elements	37 <span class='ta-none' expected-action='auto'>Touch-action should be ignored on inline elements

26 <div expected-action='auto'>And not propagated to any block children</div>	38 <div expected-action='auto'>And not propagated to any block children</div>

27 </span>	39 </span>

28 </div>	40 </div>

29 <p>Below case is broken, should be AUTO - <a href='http://crbug.com/319479'>Bug 319479</a></p>	41

30 <div class='ta-none' style='height: 0; margin-bottom: 100px'>	42 <div class='ta-none' style='height: 0; margin-bottom: 100px'>

31 <span expected-action='none'>	43 <span expected-action='auto'>

32 touch-action should not be inherited by inline elements	44 touch-action should not be inherited by inline elements

33 <div expected-action='none'>But is inherited by any block descendants of the m</div>	45 <div expected-action='none'>But is inherited by any block descendants of the m</div>

34 </span>	46 </span>

35 </div>	47 </div>

	48

	49 <svg class='ta-none' xmlns="http://www.w3.org/2000/svg">

	50 <circle expected-action='auto' r="50"/>

	51 </svg>
	gnana 2014/02/24 18:59:50 while running unit test, it crashes for SVG while while running unit test, it crashes for SVG while accessing height() RefPtr<WebCore::ClientRectList> rects = element->getClientRects(); ASSERT_GE(rects->length(), 0u) << failureContext; RefPtr<WebCore::ClientRect> r = rects->item(0); WebCore::FloatRect clientFloatRect = WebCore::FloatRect(r->left(), r->top(), r->width(), r->height()); need to check this. any suggestion will be helpful Rick Byers 2014/02/25 22:52:03 Oh, looks like I should have had an ASSERT_GT inst Show quoted text On 2014/02/24 18:59:50, gnana wrote: > while running unit test, it crashes for SVG while accessing height() > > RefPtr<WebCore::ClientRectList> rects = element->getClientRects(); > ASSERT_GE(rects->length(), 0u) << failureContext; > RefPtr<WebCore::ClientRect> r = rects->item(0); > WebCore::FloatRect clientFloatRect = WebCore::FloatRect(r->left(), > r->top(), r->width(), r->height()); > > need to check this. any suggestion will be helpful Oh, looks like I should have had an ASSERT_GT instead of an ASSERT_GE here - sorry about that. Presumably ClientRectList::length is 0 in this case (I didn't expect to have expected-action on SVG elements). Once you switch to ASSERT_GT it'll just fail the ASSERT instead of crashing. I think it's fine not to test this case, just test the SVG root case similar to your table-cell case (i.e. the expected-action is on the <svg> element, and the class='ta-none' is on a 0-size parent div). gnana 2014/02/27 13:26:59 Added test for svg root alone. Done. Show quoted text On 2014/02/25 22:52:03, Rick Byers wrote: > On 2014/02/24 18:59:50, gnana wrote: > > while running unit test, it crashes for SVG while accessing height() > > > > RefPtr<WebCore::ClientRectList> rects = element->getClientRects(); > > ASSERT_GE(rects->length(), 0u) << failureContext; > > RefPtr<WebCore::ClientRect> r = rects->item(0); > > WebCore::FloatRect clientFloatRect = WebCore::FloatRect(r->left(), > > r->top(), r->width(), r->height()); > > > > need to check this. any suggestion will be helpful > > Oh, looks like I should have had an ASSERT_GT instead of an ASSERT_GE here - > sorry about that. Presumably ClientRectList::length is 0 in this case (I didn't > expect to have expected-action on SVG elements). Once you switch to ASSERT_GT > it'll just fail the ASSERT instead of crashing. I think it's fine not to test > this case, just test the SVG root case similar to your table-cell case (i.e. the > expected-action is on the <svg> element, and the class='ta-none' is on a 0-size > parent div). Added test for svg root alone. Done.
OLD	NEW

« Source/web/tests/TouchActionTest.cpp ('K') | « Source/web/tests/TouchActionTest.cpp ('k') | no next file » | no next file with comments »