Issue 137123005: dart2js: Implement instanceMembers and staticMembers.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 137123005: dart2js: Implement instanceMembers and staticMembers. (Closed)

Created:
6 years, 11 months ago by rmacnak

Modified:
6 years, 11 months ago

Reviewers:
ahe

CC:
reviews_dartlang.org, vm-dev_dartlang.org, karlklose, floitsch

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

dart2js: Implement instanceMembers and staticMembers. BUG=http://dartbug.com/14633 Committed: https://code.google.com/p/dart/source/detail?r=31808

Created: 6 years, 11 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+321 lines, -46 lines)			Patch
M	runtime/lib/mirrors_impl.dart	View	4 chunks	+4 lines, -4 lines	0 comments	Download
M	sdk/lib/_internal/lib/js_mirrors.dart	View	9 chunks	+185 lines, -21 lines	0 comments	Download
M	tests/lib/lib.status	View	1 chunk	+0 lines, -2 lines	0 comments	Download
A	tests/lib/mirrors/declarations_model_easier.dart	View	1 chunk	+86 lines, -0 lines	0 comments	Download
A +	tests/lib/mirrors/instance_members_easier_test.dart	View	3 chunks	+44 lines, -10 lines	0 comments	Download
A +	tests/lib/mirrors/static_members_easier_test.dart	View	2 chunks	+2 lines, -9 lines	0 comments	Download

Total messages: 2 (0 generated)

rmacnak

Reapply https://codereview.chromium.org/94093011/ and add missing stubs for location/metadata caught by dart2js/analyze_api_test.

6 years, 11 months ago (2014-01-13 23:27:30 UTC) #1

rmacnak

6 years, 11 months ago (2014-01-14 22:31:28 UTC) #2

Message was sent while issue was closed.

Committed patchset #2 manually as r31808 (presubmit successful).