Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(296)

Unified Diff: runtime/lib/mirrors_impl.dart

Issue 137123005: dart2js: Implement instanceMembers and staticMembers. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Created 6 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | sdk/lib/_internal/lib/js_mirrors.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: runtime/lib/mirrors_impl.dart
diff --git a/runtime/lib/mirrors_impl.dart b/runtime/lib/mirrors_impl.dart
index 7a337304068e4ec82e16bfa2bbc5b2286a68145b..cd8182f713c69e43510b4beb22e21adf14c6cc26 100644
--- a/runtime/lib/mirrors_impl.dart
+++ b/runtime/lib/mirrors_impl.dart
@@ -199,8 +199,8 @@ class _SyntheticAccessor implements MethodMirror {
}
List<InstanceMirror> get metadata => emptyList;
-
String get source => null;
+ SourceLocation get location => throw new UnimplementedError();
}
class _SyntheticSetterParameter implements ParameterMirror {
@@ -223,6 +223,7 @@ class _SyntheticSetterParameter implements ParameterMirror {
bool get hasDefaultValue => false;
InstanceMirror get defaultValue => null;
List<InstanceMirror> get metadata => emptyList;
+ SourceLocation get location => throw new UnimplementedError();
}
abstract class _LocalObjectMirror extends _LocalMirror implements ObjectMirror {
@@ -567,8 +568,7 @@ class _LocalClassMirror extends _LocalObjectMirror
if (_cachedStaticMembers == null) {
var result = new Map<Symbol, MethodMirror>();
declarations.values.forEach((decl) {
- if (decl is MethodMirror && decl.isStatic &&
- !decl.isConstructor && !decl.isAbstract) {
+ if (decl is MethodMirror && decl.isStatic && !decl.isConstructor) {
result[decl.simpleName] = decl;
}
if (decl is VariableMirror && decl.isStatic) {
@@ -1086,7 +1086,7 @@ class _LocalLibraryMirror extends _LocalObjectMirror implements LibraryMirror {
if (_cachedTopLevelMembers == null) {
var result = new Map<Symbol, MethodMirror>();
declarations.values.forEach((decl) {
- if (decl is MethodMirror && !decl.isAbstract) {
+ if (decl is MethodMirror) {
result[decl.simpleName] = decl;
}
if (decl is VariableMirror) {
« no previous file with comments | « no previous file | sdk/lib/_internal/lib/js_mirrors.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698