runtime/vm/dart.cc - Issue 1371193005: VM restart + shutdown fixes

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: runtime/vm/dart.cc

Issue 1371193005: VM restart + shutdown fixes (Closed) Base URL: git@github.com:dart-lang/sdk.git@master

Patch Set: more code review Created 5 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: runtime/vm/dart.cc

diff --git a/runtime/vm/dart.cc b/runtime/vm/dart.cc

index 8061e9d5eefc16cc196a9d4ac005588776e463f6..1d9105de5405f81c22d2504c0e3c81ccc46dbb19 100644

--- a/runtime/vm/dart.cc

+++ b/runtime/vm/dart.cc

@@ -233,7 +233,7 @@ const char* Dart::Cleanup() {

Isolate::DisableIsolateCreation();

// Send the OOB Kill message to all remaining application isolates.

- Isolate::KillAllIsolates();

+ Isolate::KillAllIsolates(Isolate::kInternalKillMsg);

// Shutdown the service isolate.

ServiceIsolate::Shutdown();

« no previous file with comments | « runtime/observatory/tests/service/vm_restart_test.dart ('k') | runtime/vm/dart_api_impl.cc » ('j') | no next file with comments »