Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(895)

Side by Side Diff: runtime/vm/dart.cc

Issue 1371193005: VM restart + shutdown fixes (Closed) Base URL: git@github.com:dart-lang/sdk.git@master
Patch Set: more code review Created 5 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « runtime/observatory/tests/service/vm_restart_test.dart ('k') | runtime/vm/dart_api_impl.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2013, the Dart project authors. Please see the AUTHORS file 1 // Copyright (c) 2013, the Dart project authors. Please see the AUTHORS file
2 // for details. All rights reserved. Use of this source code is governed by a 2 // for details. All rights reserved. Use of this source code is governed by a
3 // BSD-style license that can be found in the LICENSE file. 3 // BSD-style license that can be found in the LICENSE file.
4 4
5 #include "vm/dart.h" 5 #include "vm/dart.h"
6 6
7 #include "vm/code_observers.h" 7 #include "vm/code_observers.h"
8 #include "vm/cpu.h" 8 #include "vm/cpu.h"
9 #include "vm/dart_api_state.h" 9 #include "vm/dart_api_state.h"
10 #include "vm/dart_entry.h" 10 #include "vm/dart_entry.h"
(...skipping 215 matching lines...) Expand 10 before | Expand all | Expand 10 after
226 } 226 }
227 227
228 // Shut down profiling. 228 // Shut down profiling.
229 Profiler::Shutdown(); 229 Profiler::Shutdown();
230 230
231 if (FLAG_shutdown) { 231 if (FLAG_shutdown) {
232 // Disable the creation of new isolates. 232 // Disable the creation of new isolates.
233 Isolate::DisableIsolateCreation(); 233 Isolate::DisableIsolateCreation();
234 234
235 // Send the OOB Kill message to all remaining application isolates. 235 // Send the OOB Kill message to all remaining application isolates.
236 Isolate::KillAllIsolates(); 236 Isolate::KillAllIsolates(Isolate::kInternalKillMsg);
237 237
238 // Shutdown the service isolate. 238 // Shutdown the service isolate.
239 ServiceIsolate::Shutdown(); 239 ServiceIsolate::Shutdown();
240 240
241 // Wait for all application isolates and the service isolate to shutdown 241 // Wait for all application isolates and the service isolate to shutdown
242 // before shutting down the thread pool. 242 // before shutting down the thread pool.
243 WaitForIsolateShutdown(); 243 WaitForIsolateShutdown();
244 244
245 // Shutdown the thread pool. On return, all thread pool threads have exited. 245 // Shutdown the thread pool. On return, all thread pool threads have exited.
246 delete thread_pool_; 246 delete thread_pool_;
(...skipping 172 matching lines...) Expand 10 before | Expand all | Expand 10 after
419 return predefined_handles_->handles_.IsValidScopedHandle(address); 419 return predefined_handles_->handles_.IsValidScopedHandle(address);
420 } 420 }
421 421
422 422
423 bool Dart::IsReadOnlyApiHandle(Dart_Handle handle) { 423 bool Dart::IsReadOnlyApiHandle(Dart_Handle handle) {
424 ASSERT(predefined_handles_ != NULL); 424 ASSERT(predefined_handles_ != NULL);
425 return predefined_handles_->api_handles_.IsValidHandle(handle); 425 return predefined_handles_->api_handles_.IsValidHandle(handle);
426 } 426 }
427 427
428 } // namespace dart 428 } // namespace dart
OLDNEW
« no previous file with comments | « runtime/observatory/tests/service/vm_restart_test.dart ('k') | runtime/vm/dart_api_impl.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698