Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(12)

Issue 1371113002: Reset to us qwerty VK if called chrome.virtualKeyboardPrivate.setHotrodKeyboard(false) (Closed)

Created:
5 years, 2 months ago by bshe
Modified:
5 years, 2 months ago
Reviewers:
rsadam
CC:
chromium-reviews, chromium-apps-reviews_chromium.org, extensions-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Reset to us qwerty VK if called chrome.virtualKeyboardPrivate.setHotrodKeyboard(false) BUG=536783 Committed: https://crrev.com/c24454c884d91053bdfadeaad5801f4a5ef3aab3 Cr-Commit-Position: refs/heads/master@{#351076}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M chrome/browser/extensions/api/virtual_keyboard_private/chrome_virtual_keyboard_delegate.cc View 1 chunk +1 line, -1 line 0 comments Download

Depends on Patchset:

Messages

Total messages: 9 (2 generated)
bshe
Hey Raheem. Do you mind to take a look at this CL? We want to ...
5 years, 2 months ago (2015-09-28 14:44:17 UTC) #2
rsadam
lgtm
5 years, 2 months ago (2015-09-28 14:59:43 UTC) #3
rsadam
On 2015/09/28 14:59:43, rsadam wrote: > lgtm Actually on second thought this doesn't make sense ...
5 years, 2 months ago (2015-09-28 15:00:49 UTC) #4
rsadam
Ignore last comment, still lgtm!
5 years, 2 months ago (2015-09-28 15:30:30 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1371113002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1371113002/1
5 years, 2 months ago (2015-09-28 15:36:09 UTC) #7
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 2 months ago (2015-09-28 16:05:02 UTC) #8
commit-bot: I haz the power
5 years, 2 months ago (2015-09-28 16:06:36 UTC) #9
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/c24454c884d91053bdfadeaad5801f4a5ef3aab3
Cr-Commit-Position: refs/heads/master@{#351076}

Powered by Google App Engine
This is Rietveld 408576698