pkg/analysis_server/lib/src/computer/computer_hover.dart - Issue 1370833002: Remove ElementLocator.locateWithOffset altogether.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: pkg/analysis_server/lib/src/computer/computer_hover.dart

Issue 1370833002: Remove ElementLocator.locateWithOffset altogether. (Closed) Base URL: git@github.com:dart-lang/sdk.git@master

Patch Set: Created 5 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: pkg/analysis_server/lib/src/computer/computer_hover.dart

diff --git a/pkg/analysis_server/lib/src/computer/computer_hover.dart b/pkg/analysis_server/lib/src/computer/computer_hover.dart

index e80a243ac0884c9b4c5843c6f53fc308839d39d4..c09668b73937075f70b217a00996969bfb677548 100644

--- a/pkg/analysis_server/lib/src/computer/computer_hover.dart

+++ b/pkg/analysis_server/lib/src/computer/computer_hover.dart

@@ -83,7 +83,7 @@ class DartUnitHoverComputer {

HoverInformation hover =

new HoverInformation(expression.offset, expression.length);

// element

- Element element = ElementLocator.locateWithOffset(expression, _offset);

+ Element element = ElementLocator.locate(expression);

if (element != null) {

// variable, if synthetic accessor

if (element is PropertyAccessorElement) {