Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(14)

Unified Diff: pkg/analysis_server/lib/src/analysis_server.dart

Issue 1370833002: Remove ElementLocator.locateWithOffset altogether. (Closed) Base URL: git@github.com:dart-lang/sdk.git@master
Patch Set: Created 5 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | pkg/analysis_server/lib/src/computer/computer_hover.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: pkg/analysis_server/lib/src/analysis_server.dart
diff --git a/pkg/analysis_server/lib/src/analysis_server.dart b/pkg/analysis_server/lib/src/analysis_server.dart
index 964ece2d88f33f99008abaac2260111cb15e5fb9..cee35085e5efb16e989cefc6ab7c0ba23c891c1f 100644
--- a/pkg/analysis_server/lib/src/analysis_server.dart
+++ b/pkg/analysis_server/lib/src/analysis_server.dart
@@ -556,7 +556,7 @@ class AnalysisServer {
*/
List<Element> getElementsAtOffset(String file, int offset) {
List<AstNode> nodes = getNodesAtOffset(file, offset);
- return getElementsOfNodes(nodes, offset);
+ return getElementsOfNodes(nodes);
}
/**
@@ -564,7 +564,7 @@ class AnalysisServer {
*
* May be empty if not resolved, but not `null`.
*/
- List<Element> getElementsOfNodes(List<AstNode> nodes, int offset) {
+ List<Element> getElementsOfNodes(List<AstNode> nodes) {
List<Element> elements = <Element>[];
for (AstNode node in nodes) {
if (node is SimpleIdentifier && node.parent is LibraryIdentifier) {
@@ -573,7 +573,7 @@ class AnalysisServer {
if (node is LibraryIdentifier) {
node = node.parent;
}
- Element element = ElementLocator.locateWithOffset(node, offset);
+ Element element = ElementLocator.locate(node);
if (node is SimpleIdentifier && element is PrefixElement) {
element = getImportElement(node);
}
« no previous file with comments | « no previous file | pkg/analysis_server/lib/src/computer/computer_hover.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698