Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(23)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 137083002: Get rid of ContextualMode for call ICs. (Closed)

Created:
6 years, 11 months ago by Toon Verwaest
Modified:
6 years, 11 months ago
Reviewers:
mvstanton
CC:
v8-dev
Visibility:
Public.

Description

Get rid of ContextualMode for call ICs. BUG= R=mvstanton@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=18594

Patch Set 1 : #

Patch Set 2 : Restore HCallGlobal until a follow-up CL #

Unified diffs Side-by-side diffs Delta from patch set Stats (+41 lines, -73 lines) Patch
M src/arm/full-codegen-arm.cc View 2 chunks +3 lines, -6 lines 0 comments Download
M src/arm/lithium-codegen-arm.cc View 1 2 chunks +2 lines, -4 lines 0 comments Download
M src/ast.h View 1 chunk +1 line, -2 lines 0 comments Download
M src/ast.cc View 2 chunks +2 lines, -3 lines 0 comments Download
M src/ia32/full-codegen-ia32.cc View 2 chunks +3 lines, -5 lines 0 comments Download
M src/ia32/lithium-codegen-ia32.cc View 1 2 chunks +2 lines, -4 lines 0 comments Download
M src/ic.h View 3 chunks +5 lines, -6 lines 0 comments Download
M src/ic.cc View 1 chunk +1 line, -2 lines 0 comments Download
M src/stub-cache.h View 3 chunks +3 lines, -5 lines 0 comments Download
M src/stub-cache.cc View 3 chunks +7 lines, -12 lines 0 comments Download
M src/type-info.h View 1 chunk +0 lines, -1 line 0 comments Download
M src/type-info.cc View 1 chunk +1 line, -4 lines 0 comments Download
M src/typing.cc View 1 chunk +1 line, -4 lines 0 comments Download
M src/x64/full-codegen-x64.cc View 2 chunks +3 lines, -6 lines 0 comments Download
M src/x64/lithium-codegen-x64.cc View 1 2 chunks +2 lines, -4 lines 0 comments Download
M test/cctest/test-heap.cc View 1 chunk +1 line, -1 line 0 comments Download
M test/mjsunit/regress/regress-2284.js View 1 chunk +3 lines, -3 lines 0 comments Download
M test/mjsunit/regress/regress-2286.js View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 6 (0 generated)
Toon Verwaest
PTAL. Depends on https://codereview.chromium.org/131663003/ and https://codereview.chromium.org/136403005/.
6 years, 11 months ago (2014-01-13 17:55:03 UTC) #1
mvstanton
Provided no other changes are required downwind of checking in the CLs that this depends ...
6 years, 11 months ago (2014-01-13 18:53:41 UTC) #2
mvstanton
I will take another look due to the changes...
6 years, 11 months ago (2014-01-14 14:44:47 UTC) #3
Toon Verwaest
Remove HCallGlobal changes and moved to https://codereview.chromium.org/134333007. PTAL at the platform ports.
6 years, 11 months ago (2014-01-14 15:45:18 UTC) #4
mvstanton
Nice, thx, lgtm.
6 years, 11 months ago (2014-01-14 15:47:48 UTC) #5
Toon Verwaest
6 years, 11 months ago (2014-01-14 16:15:19 UTC) #6
Message was sent while issue was closed. 
Committed patchset #2 manually as r18594 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698