Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(120)

Issue 134333007: Remove HCallGlobal and merge uses with HCallNamed. (Closed)

Created:
6 years, 11 months ago by Toon Verwaest
Modified:
6 years, 11 months ago
Reviewers:
mvstanton
CC:
v8-dev
Visibility:
Public.

Description

Remove HCallGlobal and merge uses with HCallNamed. R=mvstanton@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=18595

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -156 lines) Patch
M src/arm/lithium-arm.h View 2 chunks +0 lines, -19 lines 0 comments Download
M src/arm/lithium-arm.cc View 2 chunks +0 lines, -12 lines 0 comments Download
M src/arm/lithium-codegen-arm.cc View 1 chunk +0 lines, -11 lines 0 comments Download
M src/hydrogen.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M src/hydrogen-instructions.h View 2 chunks +0 lines, -21 lines 0 comments Download
M src/hydrogen-instructions.cc View 1 chunk +0 lines, -6 lines 0 comments Download
M src/ia32/lithium-codegen-ia32.cc View 1 chunk +0 lines, -11 lines 0 comments Download
M src/ia32/lithium-ia32.h View 2 chunks +0 lines, -19 lines 0 comments Download
M src/ia32/lithium-ia32.cc View 2 chunks +0 lines, -13 lines 0 comments Download
M src/x64/lithium-codegen-x64.cc View 1 chunk +0 lines, -10 lines 0 comments Download
M src/x64/lithium-x64.h View 2 chunks +0 lines, -19 lines 0 comments Download
M src/x64/lithium-x64.cc View 2 chunks +0 lines, -13 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
Toon Verwaest
PTAL
6 years, 11 months ago (2014-01-14 15:44:38 UTC) #1
mvstanton
Right on. Thank you, lgtm.
6 years, 11 months ago (2014-01-14 15:48:05 UTC) #2
Toon Verwaest
6 years, 11 months ago (2014-01-14 16:16:03 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 manually as r18595 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698