pkg/analyzer/lib/src/generated/resolver.dart - Issue 1370793002: Improve the handling of inference for instance fields in the task model

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: pkg/analyzer/lib/src/generated/resolver.dart

Issue 1370793002: Improve the handling of inference for instance fields in the task model (Closed) Base URL: git@github.com:dart-lang/sdk.git@master

Patch Set: Created 5 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: pkg/analyzer/lib/src/generated/resolver.dart

diff --git a/pkg/analyzer/lib/src/generated/resolver.dart b/pkg/analyzer/lib/src/generated/resolver.dart

index 6061588823e0a5aa1fd874d3d704acb081607bf2..0996a58c0d4845184b02d36ea00038ebd89295db 100644

--- a/pkg/analyzer/lib/src/generated/resolver.dart

+++ b/pkg/analyzer/lib/src/generated/resolver.dart

@@ -9671,7 +9671,7 @@ class PartialResolverVisitor extends ResolverVisitor {

@override

Object visitFieldDeclaration(FieldDeclaration node) {

- if (strongMode && node.isStatic) {

+ if (strongMode) {

_addStaticVariables(node.fields.variables);

Brian Wilkerson 2015/09/25 20:50:17 nit: we should change the name _addStaticVariables

Leaf 2015/09/26 00:09:33 Done.

bool wasDiscarding = discardErrorsInInitializer;

discardErrorsInInitializer = true;

« no previous file with comments | « no previous file | pkg/analyzer/lib/src/task/dart.dart » ('j') | pkg/analyzer/test/src/task/dart_test.dart » ('J')