Improve the handling of inference for instance fields in the task model

pkg/analyzer/lib/src/generated/resolver.dart

 // Copyright (c) 2014, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 library engine.resolver;
 
 import 'dart:collection';
 
 import 'ast.dart';
 import 'constant.dart';
@@ skipping 9653 matching lines @@
   @override
   Object visitExpressionFunctionBody(ExpressionFunctionBody node) {
     if (_shouldBeSkipped(node)) {
       return null;
     }
     return super.visitExpressionFunctionBody(node);
   }
 
   @override
   Object visitFieldDeclaration(FieldDeclaration node) {
-    if (strongMode && node.isStatic) {
+    if (strongMode) {
       _addStaticVariables(node.fields.variables);

[Brian Wilkerson, 2015/09/25 20:50:17]

nit: we should change the name _addStaticVariables given that they aren't
necessarily static.

[Leaf, 2015/09/26 00:09:33]

Done.

       bool wasDiscarding = discardErrorsInInitializer;
       discardErrorsInInitializer = true;
       try {
         return super.visitFieldDeclaration(node);
       } finally {
         discardErrorsInInitializer = wasDiscarding;
       }
     }
     return super.visitFieldDeclaration(node);
   }
@@ skipping 6269 matching lines @@
     nonFields.add(node);
     return null;
   }
 
   @override
   Object visitNode(AstNode node) => node.accept(TypeResolverVisitor_this);
 
   @override
   Object visitWithClause(WithClause node) => null;
 }