Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(97)

Issue 137063007: Experimental parser: make marker local (Closed)

Created:
6 years, 11 months ago by dcarney
Modified:
6 years, 11 months ago
Reviewers:
marja
CC:
v8-dev
Visibility:
Public.

Description

Experimental parser: make marker local TBR=marja@chromium.org BUG= Committed: https://code.google.com/p/v8/source/detail?r=18607

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -7 lines) Patch
M src/lexer/experimental-scanner.h View 4 chunks +0 lines, -5 lines 0 comments Download
M tools/lexer_generator/code_generator.jinja View 4 chunks +5 lines, -2 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
dcarney
Committed patchset #1 manually as r18607 (presubmit successful).
6 years, 11 months ago (2014-01-15 08:23:07 UTC) #1
marja
Hmmh, why? When we make the lexer pauseable, we need to undo this change (if ...
6 years, 11 months ago (2014-01-15 08:38:33 UTC) #2
dcarney
6 years, 11 months ago (2014-01-15 08:45:25 UTC) #3
Message was sent while issue was closed.
On 2014/01/15 08:38:33, marja wrote:
> Hmmh, why? When we make the lexer pauseable, we need to undo this change (if
the
> data ends before we have processed the marker, we need to remember where it
was
> when we get more data.)

pausable will mean a whole pile of local state will need to be stored, not just
this
there's simplly no reason for this to exist in the class, as it's local to a
single scan invocation

Powered by Google App Engine
This is Rietveld 408576698