Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(110)

Issue 1370583002: Don’t smash globals used by the test helper itself. (Closed)

Created:
5 years, 3 months ago by stefan.penner
Modified:
5 years, 3 months ago
Reviewers:
domenic, Dan Ehrenberg
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Don’t smash globals used by the test helper itself. Since https://codereview.chromium.org/366103005 the promise tests null out various globals, to ensure the promise implementation doesn’t itself rely on functions patchable by monkeys. Unfortunately, doing so breaks test assertion failures which rely on those globals. This isn’t the ideal solution, but does improve the current state. R=littledan@chromium.org,domenic@chromium.org LOG=N BUG= Committed: https://crrev.com/ab9898980eeeaedc99c8f539bac9e72fad8383a4 Cr-Commit-Position: refs/heads/master@{#30922}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -2 lines) Patch
M AUTHORS View 1 chunk +1 line, -0 lines 0 comments Download
M test/mjsunit/es6/promises.js View 2 chunks +9 lines, -2 lines 0 comments Download

Messages

Total messages: 6 (1 generated)
stefan.penner
Don’t smash globals used by the test helper itself. Since https://codereview.chromium.org/366103005 the promise tests null ...
5 years, 3 months ago (2015-09-24 21:17:43 UTC) #1
Dan Ehrenberg
lgtm
5 years, 3 months ago (2015-09-24 21:23:20 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1370583002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1370583002/1
5 years, 3 months ago (2015-09-24 21:23:34 UTC) #4
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 3 months ago (2015-09-24 21:47:13 UTC) #5
commit-bot: I haz the power
5 years, 3 months ago (2015-09-24 21:47:51 UTC) #6
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/ab9898980eeeaedc99c8f539bac9e72fad8383a4
Cr-Commit-Position: refs/heads/master@{#30922}

Powered by Google App Engine
This is Rietveld 408576698