Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(62)

Issue 366103005: Avoid brittle use of .bind in Promise.all (Closed)

Created:
6 years, 5 months ago by rossberg
Modified:
6 years, 5 months ago
Reviewers:
Yang
CC:
v8-dev
Project:
v8
Visibility:
Public.

Description

Avoid brittle use of .bind in Promise.all R=yangguo@chromium.org BUG=v8:3420 LOG=Y Committed: https://code.google.com/p/v8/source/detail?r=22231

Patch Set 1 #

Patch Set 2 : Thorough test & rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+48 lines, -8 lines) Patch
M src/promise.js View 1 chunk +9 lines, -5 lines 0 comments Download
M test/mjsunit/es6/promises.js View 1 3 chunks +39 lines, -3 lines 0 comments Download

Messages

Total messages: 7 (0 generated)
rossberg
6 years, 5 months ago (2014-07-03 12:04:27 UTC) #1
Yang
On 2014/07/03 12:04:27, rossberg wrote: lgtm.
6 years, 5 months ago (2014-07-03 12:06:50 UTC) #2
mathiasb
DBC: Should we also add a test to avoid regressions?
6 years, 5 months ago (2014-07-03 13:05:53 UTC) #3
Yang
On 2014/07/03 13:05:53, mathiasb wrote: > DBC: Should we also add a test to avoid ...
6 years, 5 months ago (2014-07-03 13:08:31 UTC) #4
rossberg
On 2014/07/03 13:08:31, Yang wrote: > On 2014/07/03 13:05:53, mathiasb wrote: > > DBC: Should ...
6 years, 5 months ago (2014-07-03 15:36:57 UTC) #5
Yang
On 2014/07/03 15:36:57, rossberg wrote: > On 2014/07/03 13:08:31, Yang wrote: > > On 2014/07/03 ...
6 years, 5 months ago (2014-07-07 06:33:24 UTC) #6
rossberg
6 years, 5 months ago (2014-07-07 09:47:52 UTC) #7
Message was sent while issue was closed.
Committed patchset #2 manually as r22231.

Powered by Google App Engine
This is Rietveld 408576698