Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(172)

Issue 137033002: Use VTTScanner for VTT region settings parsing (Closed)

Created:
6 years, 11 months ago by fs
Modified:
6 years, 11 months ago
CC:
blink-reviews, nessy, philipj_slow, gasubic, dglazkov+blink, adamk+blink_chromium.org, vcarbune.chromium
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Visibility:
Public.

Description

Use VTTScanner for VTT region settings parsing Start transitioning the VTTRegion settings parsing code to use VTTScanner, by modifying VTTRegion::parseSetting (the "name=value pair"- part of the parsing) to use VTTScanner. Remove VTTParser::collectWord since it becomes unused. BUG=305317 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=165149

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+46 lines, -36 lines) Patch
M Source/core/html/track/vtt/VTTParser.h View 1 chunk +0 lines, -1 line 0 comments Download
M Source/core/html/track/vtt/VTTParser.cpp View 1 chunk +0 lines, -8 lines 0 comments Download
M Source/core/html/track/vtt/VTTRegion.h View 2 chunks +2 lines, -1 line 0 comments Download
M Source/core/html/track/vtt/VTTRegion.cpp View 3 chunks +21 lines, -22 lines 0 comments Download
M Source/core/html/track/vtt/VTTScanner.h View 2 chunks +13 lines, -0 lines 0 comments Download
M Source/core/html/track/vtt/VTTScannerTest.cpp View 4 chunks +10 lines, -4 lines 0 comments Download

Messages

Total messages: 7 (0 generated)
fs
6 years, 11 months ago (2014-01-14 10:00:34 UTC) #1
fs
6 years, 11 months ago (2014-01-15 09:55:21 UTC) #2
jochen (gone - plz use gerrit)
i'm deferring to Mike
6 years, 11 months ago (2014-01-15 13:24:09 UTC) #3
Mike West
On 2014/01/15 13:24:09, jochen wrote: > i'm deferring to Mike I'm deferring to... oh. Crap. ...
6 years, 11 months ago (2014-01-15 14:13:57 UTC) #4
Mike West
LGTM. Thanks for making this simpler.
6 years, 11 months ago (2014-01-15 14:27:20 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/fs@opera.com/137033002/1
6 years, 11 months ago (2014-01-15 16:56:51 UTC) #6
commit-bot: I haz the power
6 years, 11 months ago (2014-01-15 17:20:35 UTC) #7
Message was sent while issue was closed.
Change committed as 165149

Powered by Google App Engine
This is Rietveld 408576698