Source/core/html/track/vtt/VTTRegion.h - Issue 137033002: Use VTTScanner for VTT region settings parsing

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/html/track/vtt/VTTRegion.h

Issue 137033002: Use VTTScanner for VTT region settings parsing (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Created 6 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: Source/core/html/track/vtt/VTTRegion.h

diff --git a/Source/core/html/track/vtt/VTTRegion.h b/Source/core/html/track/vtt/VTTRegion.h

index f9452c22498fc2b14f7658850f04c81ee695eccb..2b414871708abc8567be70cd163709c428c5a2fc 100644

--- a/Source/core/html/track/vtt/VTTRegion.h

+++ b/Source/core/html/track/vtt/VTTRegion.h

@@ -43,6 +43,7 @@ namespace WebCore {

class ExceptionState;

class HTMLDivElement;

class VTTCueBox;

+class VTTScanner;

class VTTRegion : public RefCounted<VTTRegion> {

public:

@@ -112,7 +113,7 @@ private:

ViewportAnchor,

Scroll

};

- RegionSetting getSettingFromString(const String&);

+ RegionSetting scanSettingName(VTTScanner&);

void parseSettingValue(RegionSetting, const String&);

void parseSetting(const String&, unsigned*);

« no previous file with comments | « Source/core/html/track/vtt/VTTParser.cpp ('k') | Source/core/html/track/vtt/VTTRegion.cpp » ('j') | no next file with comments »