Issue 1370133007: Merge to XFA: Introduce kPerIsolateDataIndex and tidy JS_Define.h

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1370133007: Merge to XFA: Introduce kPerIsolateDataIndex and tidy JS_Define.h (Closed)

Created:
5 years, 2 months ago by Tom Sepez

Modified:
5 years, 2 months ago

Reviewers:
jochen (gone - plz use gerrit)

CC:
pdfium-reviews_googlegroups.com

Base URL:
https://pdfium.googlesource.com/pdfium.git@xfa

Target Ref:
refs/heads/xfa

Visibility:
Public.

Merge to XFA: Introduce kPerIsolateDataIndex and tidy JS_Define.h (cherry picked from commit d6d9dc6b9a45368abdf43477592ee9f6cdb6102e) (cherry picked from commit cfff2f65aaec70247d020188bc68a0dc4fb34c3e) Original Review URL: https://codereview.chromium.org/1372963003 . Original Review URL: https://codereview.chromium.org/1367813003 . TBR=jochen@chromium.org Committed: https://pdfium.googlesource.com/pdfium/+/bd7fabf61f41e5ac2ded12ac46a4193c3dbffc44

Created: 5 years, 2 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+36 lines, -50 lines)			Patch
M	DEPS	View	1 chunk	+1 line, -1 line	0 comments	Download
M	fpdfsdk/include/javascript/JS_Define.h	View	7 chunks	+14 lines, -35 lines	0 comments	Download
M	fpdfsdk/include/jsapi/fxjs_v8.h	View	2 chunks	+1 line, -4 lines	0 comments	Download
M	fpdfsdk/src/jsapi/fxjs_v8.cpp	View	5 chunks	+18 lines, -8 lines	0 comments	Download
M	testing/resources/javascript/app_props_expected.txt	View	2 chunks	+2 lines, -2 lines	0 comments	Download

Total messages: 2 (0 generated)

Tom Sepez

TBR, one small merge conflict over local variable naming in JS_Define.h

5 years, 2 months ago (2015-09-28 17:31:21 UTC) #1

Tom Sepez

5 years, 2 months ago (2015-09-28 17:31:35 UTC) #2

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as
bd7fabf61f41e5ac2ded12ac46a4193c3dbffc44 (presubmit successful).