Issue 1372963003: Fix test diff caused by v8 version update

Issue 1372963003: Fix test diff caused by v8 version update (Closed)

Created:
5 years, 2 months ago by Tom Sepez

Modified:
5 years, 2 months ago

Reviewers:
Lei Zhang

CC:
pdfium-reviews_googlegroups.com

Base URL:
https://pdfium.googlesource.com/pdfium.git@master

Target Ref:
refs/heads/master

Visibility:
Public.

Fix test diff caused by v8 version update Also changes DEPS to specify a specific v8 version, this will require us to manually update this version from time to time, but also solves a longstanding problem where going back to an older version (say for bisecting) wouldn't always work. R=thestig@chromium.org Committed: https://pdfium.googlesource.com/pdfium/+/d6d9dc6b9a45368abdf43477592ee9f6cdb6102e

Created: 5 years, 2 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+3 lines, -3 lines)			Patch
	M	DEPS	View		1 chunk	+1 line, -1 line	0 comments	Download
	M	testing/resources/javascript/app_props_expected.txt	View		2 chunks	+2 lines, -2 lines	0 comments	Download

Total messages: 9 (1 generated)

Tom Sepez

On 2015/09/28 17:17:30, Lei Zhang wrote: > commit msg typo: specifiy ACK.

5 years, 2 months ago (2015-09-28 17:19:54 UTC) #8

Tom Sepez

5 years, 2 months ago (2015-09-28 17:20:20 UTC) #9

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as
d6d9dc6b9a45368abdf43477592ee9f6cdb6102e (tree was closed).