Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(156)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1370113006: AtomicStringTable should not be initialized lazily

Created:
5 years, 2 months ago by Mikhail
Modified:
5 years, 2 months ago
Reviewers:
tkent
CC:
blink-reviews, blink-reviews-wtf_chromium.org, chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@AtomitStringTable
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

This patch removes lazy initialization for both AtomicThreadTable and WTFThreadData. Therefore (1) two unneeded 'if' conditions have been removed from the 'atomicStringTable()' function which is used extremely intensively in blink and (2) the related code has been significantly simplified.

Patch Set 1 : #

Total comments: 1

Patch Set 2 : Export AtomicStringTable #

Unified diffs Side-by-side diffs Delta from patch set Stats (+66 lines, -79 lines) Patch
M third_party/WebKit/Source/wtf/ThreadingPthreads.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/wtf/ThreadingWin.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/wtf/WTFThreadData.h View 2 chunks +5 lines, -14 lines 0 comments Download
M third_party/WebKit/Source/wtf/WTFThreadData.cpp View 1 1 chunk +10 lines, -5 lines 0 comments Download
M third_party/WebKit/Source/wtf/text/AtomicString.h View 1 3 chunks +18 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/wtf/text/AtomicString.cpp View 1 3 chunks +31 lines, -58 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
Mikhail
PTAL
5 years, 2 months ago (2015-10-02 13:49:38 UTC) #3
tkent
https://codereview.chromium.org/1370113006/diff/20001/third_party/WebKit/Source/wtf/text/AtomicString.h File third_party/WebKit/Source/wtf/text/AtomicString.h (right): https://codereview.chromium.org/1370113006/diff/20001/third_party/WebKit/Source/wtf/text/AtomicString.h#newcode185 third_party/WebKit/Source/wtf/text/AtomicString.h:185: static AtomicStringTable* createAtomicStringTable(); I wonder why createAtomicStringTable and destroyAtomicStringTable ...
5 years, 2 months ago (2015-10-04 22:47:47 UTC) #4
Mikhail
On 2015/10/04 22:47:47, tkent wrote: > https://codereview.chromium.org/1370113006/diff/20001/third_party/WebKit/Source/wtf/text/AtomicString.h > File third_party/WebKit/Source/wtf/text/AtomicString.h (right): > > https://codereview.chromium.org/1370113006/diff/20001/third_party/WebKit/Source/wtf/text/AtomicString.h#newcode185 > ...
5 years, 2 months ago (2015-10-05 09:59:10 UTC) #5
Mikhail
On 2015/10/05 09:59:10, Mikhail wrote: > On 2015/10/04 22:47:47, tkent wrote: > > > https://codereview.chromium.org/1370113006/diff/20001/third_party/WebKit/Source/wtf/text/AtomicString.h ...
5 years, 2 months ago (2015-10-07 05:58:02 UTC) #6
Mikhail
5 years, 2 months ago (2015-10-12 09:43:10 UTC) #7 
On 2015/10/07 05:58:02, Mikhail wrote:
> On 2015/10/05 09:59:10, Mikhail wrote:
> > On 2015/10/04 22:47:47, tkent wrote:
> > >
> >
>
https://codereview.chromium.org/1370113006/diff/20001/third_party/WebKit/Sour...
> > > File third_party/WebKit/Source/wtf/text/AtomicString.h (right):
> > > 
> > >
> >
>
https://codereview.chromium.org/1370113006/diff/20001/third_party/WebKit/Sour...
> > > third_party/WebKit/Source/wtf/text/AtomicString.h:185: static
> > AtomicStringTable*
> > > createAtomicStringTable();
> > > I wonder why createAtomicStringTable and destroyAtomicStringTable are
> > functions
> > > of AtomciString, not AtomicStringTable.
> > AtomicStringTable has not yet been exported, fixed now.
> 
> Does the patch look ok now?
gentle ping

Powered by Google App Engine
This is Rietveld 408576698