Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(82)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1369973002: Use FeedbackVectorSlotKind instead of Code::Kind for type feedback vector. (Closed)

Created:
5 years, 2 months ago by Igor Sheludko
Modified:
5 years, 2 months ago
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Use FeedbackVectorSlotKind instead of Code::Kind for type feedback vector. This is a first step towards merging FeedbackVectorSlot and FeedbackVectorICSlot. Committed: https://crrev.com/6ca00aac1a5fde63fe767cbe4792c21b6dcfa192 Cr-Commit-Position: refs/heads/master@{#30964}

Patch Set 1 : #

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+264 lines, -217 lines) Patch
M src/ast.h View 1 11 chunks +26 lines, -14 lines 0 comments Download
M src/ast.cc View 1 4 chunks +6 lines, -5 lines 0 comments Download
M src/heap/heap.cc View 1 1 chunk +4 lines, -2 lines 0 comments Download
M src/hydrogen.cc View 1 1 chunk +2 lines, -1 line 0 comments Download
M src/ic/ic.cc View 1 4 chunks +12 lines, -8 lines 0 comments Download
M src/objects-printer.cc View 1 1 chunk +32 lines, -20 lines 0 comments Download
M src/prettyprinter.cc View 1 chunk +2 lines, -1 line 0 comments Download
M src/type-feedback-vector.h View 1 13 chunks +45 lines, -34 lines 0 comments Download
M src/type-feedback-vector.cc View 1 5 chunks +66 lines, -70 lines 0 comments Download
M src/type-info.cc View 1 4 chunks +11 lines, -10 lines 0 comments Download
M test/cctest/interpreter/test-bytecode-generator.cc View 1 3 chunks +6 lines, -3 lines 0 comments Download
M test/cctest/interpreter/test-interpreter.cc View 1 5 chunks +7 lines, -5 lines 0 comments Download
M test/cctest/test-feedback-vector.cc View 1 8 chunks +43 lines, -42 lines 0 comments Download
M test/cctest/test-heap.cc View 1 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 16 (8 generated)
Igor Sheludko
PTAL
5 years, 2 months ago (2015-09-28 07:47:53 UTC) #5
mvstanton
lgtm
5 years, 2 months ago (2015-09-28 08:05:33 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1369973002/80001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1369973002/80001
5 years, 2 months ago (2015-09-28 08:08:12 UTC) #8
commit-bot: I haz the power
Try jobs failed on following builders: v8_presubmit on tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_presubmit/builds/6124)
5 years, 2 months ago (2015-09-28 08:11:10 UTC) #10
Hannes Payer (out of office)
heap LGTM
5 years, 2 months ago (2015-09-28 08:20:52 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1369973002/80001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1369973002/80001
5 years, 2 months ago (2015-09-28 08:22:13 UTC) #14
commit-bot: I haz the power
Committed patchset #2 (id:80001)
5 years, 2 months ago (2015-09-28 08:23:42 UTC) #15
commit-bot: I haz the power
5 years, 2 months ago (2015-09-28 08:24:01 UTC) #16
Message was sent while issue was closed. 
Patchset 2 (id:??) landed as
https://crrev.com/6ca00aac1a5fde63fe767cbe4792c21b6dcfa192
Cr-Commit-Position: refs/heads/master@{#30964}

Powered by Google App Engine
This is Rietveld 408576698