Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(526)

Side by Side Diff: src/hydrogen.cc

Issue 1369973002: Use FeedbackVectorSlotKind instead of Code::Kind for type feedback vector. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: Created 5 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « src/heap/heap.cc ('k') | src/ic/ic.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2013 the V8 project authors. All rights reserved. 1 // Copyright 2013 the V8 project authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "src/hydrogen.h" 5 #include "src/hydrogen.h"
6 6
7 #include <sstream> 7 #include <sstream>
8 8
9 #include "src/allocation-site-scopes.h" 9 #include "src/allocation-site-scopes.h"
10 #include "src/ast-numbering.h" 10 #include "src/ast-numbering.h"
(...skipping 7257 matching lines...) Expand 10 before | Expand all | Expand 10 after
7268 result->SetVectorAndSlot(vector, slot); 7268 result->SetVectorAndSlot(vector, slot);
7269 return result; 7269 return result;
7270 } 7270 }
7271 7271
7272 HLoadNamedGeneric* result = New<HLoadNamedGeneric>( 7272 HLoadNamedGeneric* result = New<HLoadNamedGeneric>(
7273 object, name, function_language_mode(), PREMONOMORPHIC); 7273 object, name, function_language_mode(), PREMONOMORPHIC);
7274 result->SetVectorAndSlot(vector, slot); 7274 result->SetVectorAndSlot(vector, slot);
7275 return result; 7275 return result;
7276 } else { 7276 } else {
7277 if (FLAG_vector_stores && 7277 if (FLAG_vector_stores &&
7278 current_feedback_vector()->GetKind(slot) == Code::KEYED_STORE_IC) { 7278 current_feedback_vector()->GetKind(slot) ==
7279 FeedbackVectorSlotKind::KEYED_STORE_IC) {
7279 // It's possible that a keyed store of a constant string was converted 7280 // It's possible that a keyed store of a constant string was converted
7280 // to a named store. Here, at the last minute, we need to make sure to 7281 // to a named store. Here, at the last minute, we need to make sure to
7281 // use a generic Keyed Store if we are using the type vector, because 7282 // use a generic Keyed Store if we are using the type vector, because
7282 // it has to share information with full code. 7283 // it has to share information with full code.
7283 HConstant* key = Add<HConstant>(name); 7284 HConstant* key = Add<HConstant>(name);
7284 HStoreKeyedGeneric* result = New<HStoreKeyedGeneric>( 7285 HStoreKeyedGeneric* result = New<HStoreKeyedGeneric>(
7285 object, key, value, function_language_mode(), PREMONOMORPHIC); 7286 object, key, value, function_language_mode(), PREMONOMORPHIC);
7286 Handle<TypeFeedbackVector> vector = 7287 Handle<TypeFeedbackVector> vector =
7287 handle(current_feedback_vector(), isolate()); 7288 handle(current_feedback_vector(), isolate());
7288 result->SetVectorAndSlot(vector, slot); 7289 result->SetVectorAndSlot(vector, slot);
(...skipping 6309 matching lines...) Expand 10 before | Expand all | Expand 10 after
13598 isolate()->GetHTracer()->TraceHydrogen(name(), graph_); 13599 isolate()->GetHTracer()->TraceHydrogen(name(), graph_);
13599 } 13600 }
13600 13601
13601 #ifdef DEBUG 13602 #ifdef DEBUG
13602 graph_->Verify(false); // No full verify. 13603 graph_->Verify(false); // No full verify.
13603 #endif 13604 #endif
13604 } 13605 }
13605 13606
13606 } // namespace internal 13607 } // namespace internal
13607 } // namespace v8 13608 } // namespace v8
OLDNEW
« no previous file with comments | « src/heap/heap.cc ('k') | src/ic/ic.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698