Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(997)

Issue 1369813003: Fix telemetry_gpu_test's GN build. (Closed)

Created:
5 years, 2 months ago by Ken Russell (switch to Gerrit)
Modified:
5 years, 2 months ago
Reviewers:
Dirk Pranke, brettw
CC:
chromium-reviews, Dirk Pranke, Nico
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Fix telemetry_gpu_test's GN build. https://codereview.chromium.org/1364103002 caused an accidental regression due to an apparent bug in the handling of groups as data dependencies in GN. Thanks to dpranke@ for side-by-side debugging. Work around this. BUG=536192 TBR=brettw@chromium.org Committed: https://crrev.com/a40f71f3fc0ed46a7d0f00fa1bcb39529d5b71c9 Cr-Commit-Position: refs/heads/master@{#350960}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -1 line) Patch
M chrome/test/BUILD.gn View 1 chunk +3 lines, -1 line 0 comments Download

Messages

Total messages: 9 (3 generated)
Ken Russell (switch to Gerrit)
Thanks to dpranke@ for debugging and coming up with this workaround. CQ'ing TBR'd.
5 years, 2 months ago (2015-09-25 23:57:12 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1369813003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1369813003/1
5 years, 2 months ago (2015-09-25 23:58:07 UTC) #4
Dirk Pranke
lgtm
5 years, 2 months ago (2015-09-26 00:04:45 UTC) #6
brettw
lgtm
5 years, 2 months ago (2015-09-26 00:45:24 UTC) #7
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 2 months ago (2015-09-26 00:50:06 UTC) #8
commit-bot: I haz the power
5 years, 2 months ago (2015-09-26 00:50:46 UTC) #9
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/a40f71f3fc0ed46a7d0f00fa1bcb39529d5b71c9
Cr-Commit-Position: refs/heads/master@{#350960}

Powered by Google App Engine
This is Rietveld 408576698