Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1176)

Issue 1364103002: gn/win: Run reorder-imports.py on chrome.exe (Closed)

Created:
5 years, 3 months ago by Nico
Modified:
5 years, 3 months ago
Reviewers:
brettw
CC:
chromium-reviews, robertshield
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

gn/win: Run reorder-imports.py on chrome.exe This should fix chrome_elf_unittests and a bunch of browser_tests when using the chrome/win gn build. (The hardlinking for chrome.dll still isn't done yet though.) Also, while here: * Move chrome's dep on pdf on linux to where all the other linux deps are (no behavior change) * Let chrome be a console subsystem executable in asan builds, like in gyp BUG=505062, 512599 R=brettw@chromium.org Committed: https://chromium.googlesource.com/chromium/src/+/e9a4c96d5912a9179bb7ba45c34272d456fce762

Patch Set 1 #

Patch Set 2 : . #

Patch Set 3 : . #

Patch Set 4 : . #

Patch Set 5 : . #

Patch Set 6 : . #

Total comments: 1

Patch Set 7 : remove todo #

Total comments: 2

Patch Set 8 : comment #

Unified diffs Side-by-side diffs Delta from patch set Stats (+56 lines, -11 lines) Patch
M chrome/BUILD.gn View 1 2 3 4 5 6 7 5 chunks +54 lines, -10 lines 0 comments Download
M chrome/chrome_exe.gypi View 1 2 3 4 5 6 7 2 chunks +2 lines, -1 line 0 comments Download

Messages

Total messages: 6 (1 generated)
Nico
This should work. I haven't tested running tests with this locally, for lack of Windows ...
5 years, 3 months ago (2015-09-24 04:15:19 UTC) #2
brettw
lgtm https://codereview.chromium.org/1364103002/diff/120001/chrome/BUILD.gn File chrome/BUILD.gn (right): https://codereview.chromium.org/1364103002/diff/120001/chrome/BUILD.gn#newcode162 chrome/BUILD.gn:162: if (!is_asan) { Can you add a comment ...
5 years, 3 months ago (2015-09-24 18:19:56 UTC) #3
Nico
thanks! https://codereview.chromium.org/1364103002/diff/120001/chrome/BUILD.gn File chrome/BUILD.gn (right): https://codereview.chromium.org/1364103002/diff/120001/chrome/BUILD.gn#newcode162 chrome/BUILD.gn:162: if (!is_asan) { On 2015/09/24 18:19:56, brettw wrote: ...
5 years, 3 months ago (2015-09-24 18:28:44 UTC) #4
commit-bot: I haz the power
Patchset 8 (id:??) landed as https://crrev.com/e9a4c96d5912a9179bb7ba45c34272d456fce762 Cr-Commit-Position: refs/heads/master@{#350616}
5 years, 3 months ago (2015-09-24 18:48:52 UTC) #5
Nico
5 years, 3 months ago (2015-09-24 18:49:14 UTC) #6
Message was sent while issue was closed.
Committed patchset #8 (id:140001) manually as
e9a4c96d5912a9179bb7ba45c34272d456fce762 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698