Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(150)

Issue 1369723002: Revert of permissions: add layout tests for multiple requests (Closed)

Created:
5 years, 2 months ago by Michael van Ouwerkerk
Modified:
5 years, 2 months ago
CC:
blink-reviews
Base URL:
https://chromium.googlesource.com/chromium/blink.git@fix-request-test
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of permissions: add layout tests for multiple requests (patchset #8 id:140001 of https://codereview.chromium.org/1352863003/ ) Reason for revert: Oddly one test is failing on Win7: 535931. Sorry for the revert. Original issue's description: > permissions: add layout tests for multiple requests > > No permisisons, single, multiple and duplicate permissions > are all tested. Permission updates being reflected in the request > is also tested. > > This CL depends on https://codereview.chromium.org/1352863002/ > as it adds the ability to reset permisisons. > > BUG=516626 > > Committed: https://crrev.com/3f93847acbf05646881eddde65fc285eb60d8556 > Cr-Commit-Position: refs/heads/master@{#350677} TBR=mlamouri@chromium.org,lalitm@google.com NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=516626 Committed: https://crrev.com/1af5603ba31c286a5a942b50473d288daa89cdaa Cr-Commit-Position: refs/heads/master@{#350830}

Patch Set 1 #

Messages

Total messages: 4 (0 generated)
Michael van Ouwerkerk
Created Revert of permissions: add layout tests for multiple requests
5 years, 2 months ago (2015-09-25 15:15:20 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1369723002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1369723002/1
5 years, 2 months ago (2015-09-25 15:15:47 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 2 months ago (2015-09-25 15:16:52 UTC) #3
commit-bot: I haz the power
5 years, 2 months ago (2015-09-25 15:18:06 UTC) #4
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/1af5603ba31c286a5a942b50473d288daa89cdaa
Cr-Commit-Position: refs/heads/master@{#350830}

Powered by Google App Engine
This is Rietveld 408576698