Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(601)

Unified Diff: chrome/browser/autofill/android/personal_data_manager_android.cc

Issue 13697002: Make autofill's Address store country using the country code so that app locale isn't needed for th… (Closed) Base URL: svn://chrome-svn/chrome/trunk/src/
Patch Set: Created 7 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/autofill/android/personal_data_manager_android.cc
===================================================================
--- chrome/browser/autofill/android/personal_data_manager_android.cc (revision 192389)
+++ chrome/browser/autofill/android/personal_data_manager_android.cc (working copy)
@@ -90,11 +90,12 @@
ADDRESS_HOME_ZIP,
ConvertJavaStringToUTF16(
Java_AutofillProfile_getZip(env, jprofile)));
+ string16 country_name_or_code = ConvertJavaStringToUTF16(
+ Java_AutofillProfile_getCountry(env, jprofile))
+ std::string country_code = AutofillCountry::GetCountryCode(
+ country_name_or_code, g_browser_process->GetApplicationLocale());
+ profile->SetRawInfo(ADDRESS_HOME_COUNTRY, ASCIIToUTF16(country_code));
Ilya Sherman 2013/04/05 05:18:01 Please use SetInfo() rather than SetRawInfo() for
jam 2013/04/05 06:45:54 Done.
profile->SetRawInfo(
- ADDRESS_HOME_COUNTRY,
- ConvertJavaStringToUTF16(
- Java_AutofillProfile_getCountry(env, jprofile)));
- profile->SetRawInfo(
PHONE_HOME_WHOLE_NUMBER,
ConvertJavaStringToUTF16(
Java_AutofillProfile_getPhoneNumber(env, jprofile)));
« no previous file with comments | « no previous file | chrome/browser/autofill/autofill_browsertest.cc » ('j') | chrome/browser/autofill/autofill_browsertest.cc » ('J')

Powered by Google App Engine
This is Rietveld 408576698