Make autofill's Address store country using the country code so that app locale isn't needed for th…

chrome/browser/autofill/android/personal_data_manager_android.cc

 // Copyright 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/autofill/android/personal_data_manager_android.h"
 
 #include "base/android/jni_string.h"
 #include "base/format_macros.h"
 #include "base/stringprintf.h"
 #include "base/utf_string_conversions.h"
@@ skipping 33 matching lines @@
           env,
           profile.GetRawInfo(ADDRESS_HOME_CITY)).obj(),
       ConvertUTF16ToJavaString(
           env,
           profile.GetRawInfo(ADDRESS_HOME_STATE)).obj(),
       ConvertUTF16ToJavaString(
           env,
           profile.GetRawInfo(ADDRESS_HOME_ZIP)).obj(),
       ConvertUTF16ToJavaString(
           env,
           profile.GetRawInfo(ADDRESS_HOME_COUNTRY)).obj(),

[Ilya Sherman, 2013/04/05 05:18:01]

I think this might need to be updated to be GetInfo().

[jam, 2013/04/05 06:45:54]

I had traced through the java code to
http://developer.android.com/reference/android/provider/ContactsContract.Comm...
which says this could be name or country code.

but probably best not to test that assumption and keep as before, done

       ConvertUTF16ToJavaString(
           env,
           profile.GetRawInfo(PHONE_HOME_WHOLE_NUMBER)).obj(),
       ConvertUTF16ToJavaString(env, profile.GetRawInfo(EMAIL_ADDRESS)).obj());
 }
 
 void PopulateNativeProfileFromJava(
     const jobject& jprofile,
     JNIEnv* env,
     AutofillProfile* profile) {
@@ skipping 18 matching lines @@
       ConvertJavaStringToUTF16(
           Java_AutofillProfile_getCity(env, jprofile)));
   profile->SetRawInfo(
       ADDRESS_HOME_STATE,
       ConvertJavaStringToUTF16(
           Java_AutofillProfile_getState(env, jprofile)));
   profile->SetRawInfo(
       ADDRESS_HOME_ZIP,
       ConvertJavaStringToUTF16(
           Java_AutofillProfile_getZip(env, jprofile)));
-  profile->SetRawInfo(
-      ADDRESS_HOME_COUNTRY,
-      ConvertJavaStringToUTF16(
-          Java_AutofillProfile_getCountry(env, jprofile)));
+  string16 country_name_or_code = ConvertJavaStringToUTF16(
+      Java_AutofillProfile_getCountry(env, jprofile))
+  std::string country_code = AutofillCountry::GetCountryCode(
+      country_name_or_code, g_browser_process->GetApplicationLocale());
+  profile->SetRawInfo(ADDRESS_HOME_COUNTRY, ASCIIToUTF16(country_code));

[Ilya Sherman, 2013/04/05 05:18:01]

Please use SetInfo() rather than SetRawInfo() for this.

[jam, 2013/04/05 06:45:54]

Done.

   profile->SetRawInfo(
       PHONE_HOME_WHOLE_NUMBER,
       ConvertJavaStringToUTF16(
           Java_AutofillProfile_getPhoneNumber(env, jprofile)));
   profile->SetRawInfo(
       EMAIL_ADDRESS,
       ConvertJavaStringToUTF16(
           Java_AutofillProfile_getEmailAddress(env, jprofile)));
 }
 
@@ skipping 163 matching lines @@
 // static
 bool PersonalDataManagerAndroid::Register(JNIEnv* env) {
   return RegisterNativesImpl(env);
 }
 
 static jint Init(JNIEnv* env, jobject obj) {
   PersonalDataManagerAndroid* personal_data_manager_android =
       new PersonalDataManagerAndroid(env, obj);
   return reinterpret_cast<jint>(personal_data_manager_android);
 }