Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(42)

Issue 1369673003: [presubmit] Enable runtime/threadsafe_fn linter checking. (Closed)

Created:
5 years, 2 months ago by Michael Starzinger
Modified:
5 years, 2 months ago
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[presubmit] Enable runtime/threadsafe_fn linter checking. This enables linter checking for "runtime/threadsafe_fn" violations during presubmit and instead marks the few known exceptions that we allow explicitly. R=jochen@chromium.org Committed: https://crrev.com/6ec34c7cb3fc8f9d8fdde7e3e673da15b7ce7912 Cr-Commit-Position: refs/heads/master@{#30933}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+17 lines, -18 lines) Patch
M src/base/platform/platform-aix.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M src/base/platform/platform-cygwin.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M src/base/platform/platform-freebsd.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M src/base/platform/platform-linux.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M src/base/platform/platform-macos.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M src/base/platform/platform-openbsd.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M src/base/platform/platform-posix.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/base/platform/platform-qnx.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M src/base/platform/platform-solaris.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/base/platform/platform-win32.cc View 1 chunk +1 line, -1 line 0 comments Download
M tools/presubmit.py View 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 6 (1 generated)
Michael Starzinger
5 years, 2 months ago (2015-09-25 09:33:44 UTC) #1
jochen (gone - plz use gerrit)
lgtm
5 years, 2 months ago (2015-09-25 11:20:41 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1369673003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1369673003/1
5 years, 2 months ago (2015-09-25 11:26:00 UTC) #4
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 2 months ago (2015-09-25 11:32:42 UTC) #5
commit-bot: I haz the power
5 years, 2 months ago (2015-09-25 11:32:59 UTC) #6
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/6ec34c7cb3fc8f9d8fdde7e3e673da15b7ce7912
Cr-Commit-Position: refs/heads/master@{#30933}

Powered by Google App Engine
This is Rietveld 408576698