Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(239)

Side by Side Diff: tools/presubmit.py

Issue 1369673003: [presubmit] Enable runtime/threadsafe_fn linter checking. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: Created 5 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « src/base/platform/platform-win32.cc ('k') | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 #!/usr/bin/env python 1 #!/usr/bin/env python
2 # 2 #
3 # Copyright 2012 the V8 project authors. All rights reserved. 3 # Copyright 2012 the V8 project authors. All rights reserved.
4 # Redistribution and use in source and binary forms, with or without 4 # Redistribution and use in source and binary forms, with or without
5 # modification, are permitted provided that the following conditions are 5 # modification, are permitted provided that the following conditions are
6 # met: 6 # met:
7 # 7 #
8 # * Redistributions of source code must retain the above copyright 8 # * Redistributions of source code must retain the above copyright
9 # notice, this list of conditions and the following disclaimer. 9 # notice, this list of conditions and the following disclaimer.
10 # * Redistributions in binary form must reproduce the above 10 # * Redistributions in binary form must reproduce the above
(...skipping 45 matching lines...) Expand 10 before | Expand all | Expand 10 after
56 -build/header_guard 56 -build/header_guard
57 +build/include_alpha 57 +build/include_alpha
58 -build/include_what_you_use 58 -build/include_what_you_use
59 -build/namespaces 59 -build/namespaces
60 -readability/check 60 -readability/check
61 -readability/inheritance 61 -readability/inheritance
62 -readability/namespace 62 -readability/namespace
63 -readability/nolint 63 -readability/nolint
64 +readability/streams 64 +readability/streams
65 -runtime/references 65 -runtime/references
66 -runtime/threadsafe_fn
67 -whitespace/semicolon 66 -whitespace/semicolon
68 """.split() 67 """.split()
69 68
70 LINT_OUTPUT_PATTERN = re.compile(r'^.+[:(]\d+[:)]|^Done processing') 69 LINT_OUTPUT_PATTERN = re.compile(r'^.+[:(]\d+[:)]|^Done processing')
71 FLAGS_LINE = re.compile("//\s*Flags:.*--([A-z0-9-])+_[A-z0-9].*\n") 70 FLAGS_LINE = re.compile("//\s*Flags:.*--([A-z0-9-])+_[A-z0-9].*\n")
72 71
73 def CppLintWorker(command): 72 def CppLintWorker(command):
74 try: 73 try:
75 process = subprocess.Popen(command, stderr=subprocess.PIPE) 74 process = subprocess.Popen(command, stderr=subprocess.PIPE)
76 process.wait() 75 process.wait()
(...skipping 379 matching lines...) Expand 10 before | Expand all | Expand 10 after
456 success = SourceProcessor().Run(workspace) and success 455 success = SourceProcessor().Run(workspace) and success
457 success = CheckExternalReferenceRegistration(workspace) and success 456 success = CheckExternalReferenceRegistration(workspace) and success
458 if success: 457 if success:
459 return 0 458 return 0
460 else: 459 else:
461 return 1 460 return 1
462 461
463 462
464 if __name__ == '__main__': 463 if __name__ == '__main__':
465 sys.exit(Main()) 464 sys.exit(Main())
OLDNEW
« no previous file with comments | « src/base/platform/platform-win32.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698