Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(331)

Issue 1369643002: Add configuration and interface permission checks to DeviceImpl. (Closed)

Created:
5 years, 2 months ago by Reilly Grant (use Gerrit)
Modified:
5 years, 2 months ago
CC:
chromium-reviews, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, yzshen+watch_chromium.org, abarth-chromium, Aaron Boodman, darin (slow to review), ben+mojo_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Add configuration and interface permission checks to DeviceImpl. New methods to check whether a client has permission to access a device configuration or interface have been added to the PermissionProvider interface. DeviceManagerImpl then uses the new Bind() method to give DeviceImpl a new pointer to the object it has been using for permission checks. Permission checks are not required for bulk, interrupt and isochronous transfers because they require the interface to be claimed first. BUG=492204 Committed: https://crrev.com/83746f46774aef7ca1b7b5ef33d49a6bc90d24e2 Cr-Commit-Position: refs/heads/master@{#351408}

Patch Set 1 #

Patch Set 2 : Add new method ot Android USB mocks. #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+463 lines, -162 lines) Patch
M chrome/browser/devtools/device/usb/android_usb_browsertest.cc View 1 1 chunk +6 lines, -0 lines 0 comments Download
M chrome/browser/usb/web_usb_permission_provider.h View 2 chunks +16 lines, -3 lines 0 comments Download
M chrome/browser/usb/web_usb_permission_provider.cc View 6 chunks +56 lines, -7 lines 1 comment Download
M device/BUILD.gn View 1 chunk +2 lines, -0 lines 0 comments Download
M device/device_tests.gyp View 1 chunk +2 lines, -0 lines 0 comments Download
M device/devices_app/usb/device_impl.h View 3 chunks +15 lines, -34 lines 0 comments Download
M device/devices_app/usb/device_impl.cc View 11 chunks +170 lines, -66 lines 0 comments Download
M device/devices_app/usb/device_impl_unittest.cc View 11 chunks +48 lines, -6 lines 0 comments Download
M device/devices_app/usb/device_manager_impl.cc View 1 chunk +3 lines, -1 line 0 comments Download
M device/devices_app/usb/device_manager_impl_unittest.cc View 4 chunks +3 lines, -22 lines 0 comments Download
A device/devices_app/usb/fake_permission_provider.h View 1 chunk +42 lines, -0 lines 0 comments Download
A device/devices_app/usb/fake_permission_provider.cc View 1 1 chunk +43 lines, -0 lines 0 comments Download
M device/devices_app/usb/public/interfaces/device.mojom View 1 chunk +3 lines, -0 lines 0 comments Download
M device/devices_app/usb/public/interfaces/permission_provider.mojom View 1 chunk +15 lines, -0 lines 0 comments Download
M device/usb/mock_usb_device_handle.h View 2 chunks +14 lines, -15 lines 0 comments Download
M device/usb/usb_device.h View 2 chunks +3 lines, -5 lines 0 comments Download
M device/usb/usb_device_handle.h View 1 chunk +5 lines, -0 lines 0 comments Download
M device/usb/usb_device_handle_impl.h View 1 chunk +2 lines, -0 lines 0 comments Download
M device/usb/usb_device_handle_impl.cc View 2 chunks +15 lines, -3 lines 0 comments Download

Dependent Patchsets:

Messages

Total messages: 12 (4 generated)
Reilly Grant (use Gerrit)
Please take a look.
5 years, 2 months ago (2015-09-24 22:50:25 UTC) #2
Ken Rockot(use gerrit already)
lgtm https://codereview.chromium.org/1369643002/diff/20001/chrome/browser/usb/web_usb_permission_provider.cc File chrome/browser/usb/web_usb_permission_provider.cc (right): https://codereview.chromium.org/1369643002/diff/20001/chrome/browser/usb/web_usb_permission_provider.cc#newcode132 chrome/browser/usb/web_usb_permission_provider.cc:132: delete this; Ah right - this seems like ...
5 years, 2 months ago (2015-09-28 17:43:40 UTC) #3
Reilly Grant (use Gerrit)
pfeldman@, please look at the update to the USB mocks in android_usb_browsertest.cc.
5 years, 2 months ago (2015-09-28 18:13:26 UTC) #5
Reilly Grant (use Gerrit)
dgozman@, please look at the update to the USB mocks in android_usb_browsertest.cc.
5 years, 2 months ago (2015-09-29 20:07:59 UTC) #7
dgozman
lgtm
5 years, 2 months ago (2015-09-29 20:18:19 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1369643002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1369643002/20001
5 years, 2 months ago (2015-09-29 20:20:19 UTC) #10
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 2 months ago (2015-09-29 21:30:13 UTC) #11
commit-bot: I haz the power
5 years, 2 months ago (2015-09-29 21:31:35 UTC) #12
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/83746f46774aef7ca1b7b5ef33d49a6bc90d24e2
Cr-Commit-Position: refs/heads/master@{#351408}

Powered by Google App Engine
This is Rietveld 408576698