device/devices_app/usb/device_manager_impl.cc - Issue 1369643002: Add configuration and interface permission checks to DeviceImpl.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: device/devices_app/usb/device_manager_impl.cc

Issue 1369643002: Add configuration and interface permission checks to DeviceImpl. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Add new method ot Android USB mocks. Created 5 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/usb/web_usb_permission_provider.cc ('K') | « device/devices_app/usb/device_impl_unittest.cc ('k') | device/devices_app/usb/device_manager_impl_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: device/devices_app/usb/device_manager_impl.cc

diff --git a/device/devices_app/usb/device_manager_impl.cc b/device/devices_app/usb/device_manager_impl.cc

index 333df78bdb27cdd050b3dee24220d67746c1da15..0fc287da2196a2b32be50e1a52b76852d27d202a 100644

--- a/device/devices_app/usb/device_manager_impl.cc

+++ b/device/devices_app/usb/device_manager_impl.cc

@@ -204,7 +204,9 @@ void DeviceManagerImpl::OnGetDevicePermissionCheckComplete(

return;

DCHECK(allowed_guids.size() == 1);

- new DeviceImpl(device, device_request.Pass());

+ PermissionProviderPtr permission_provider;

+ permission_provider_->Bind(mojo::GetProxy(&permission_provider));

+ new DeviceImpl(device, permission_provider.Pass(), device_request.Pass());

}

void DeviceManagerImpl::OnGetDevices(EnumerationOptionsPtr options,