Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(392)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1369333004: Move SkAtomics.h to private. (Closed)

Created:
5 years, 2 months ago by herb_g
Modified:
5 years, 2 months ago
Reviewers:
mtklein
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Move SkAtomics.h to private. There are no API changes. TBR=reed@google.com BUG=skia: Committed: https://skia.googlesource.com/skia/+/e6e41a8a19976a822de36379db23184ff2f28601

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+29 lines, -165 lines) Patch
M bench/RefCntBench.cpp View 1 chunk +1 line, -1 line 0 comments Download
D include/core/SkAtomics.h View 1 chunk +0 lines, -136 lines 0 comments Download
M include/core/SkOnce.h View 1 chunk +1 line, -1 line 0 comments Download
M include/core/SkPixelRef.h View 1 chunk +1 line, -1 line 0 comments Download
M include/core/SkRefCnt.h View 1 chunk +1 line, -1 line 0 comments Download
M include/core/SkSpinlock.h View 1 chunk +1 line, -1 line 0 comments Download
A + include/private/SkAtomics.h View 0 chunks +-1 lines, --1 lines 0 comments Download
M include/private/SkOncePtr.h View 1 chunk +1 line, -1 line 0 comments Download
M include/private/SkSemaphore.h View 1 chunk +1 line, -1 line 0 comments Download
M include/private/SkWeakRefCnt.h View 1 chunk +1 line, -1 line 0 comments Download
M src/core/SkAAClip.cpp View 1 chunk +1 line, -1 line 0 comments Download
M src/core/SkBitmap.cpp View 1 chunk +1 line, -1 line 0 comments Download
M src/core/SkBitmapHeap.h View 1 chunk +1 line, -1 line 0 comments Download
M src/core/SkClipStack.cpp View 1 chunk +1 line, -1 line 0 comments Download
M src/core/SkDrawable.cpp View 1 chunk +1 line, -1 line 0 comments Download
M src/core/SkPicture.cpp View 1 chunk +1 line, -1 line 0 comments Download
M src/core/SkRegion.cpp View 1 chunk +1 line, -1 line 0 comments Download
M src/core/SkRegionPriv.h View 1 chunk +1 line, -1 line 0 comments Download
M src/core/SkShader.cpp View 1 chunk +1 line, -1 line 0 comments Download
M src/core/SkSharedMutex.h View 1 chunk +1 line, -1 line 0 comments Download
M src/core/SkSharedMutex.cpp View 1 chunk +1 line, -1 line 0 comments Download
M src/core/SkString.cpp View 1 chunk +1 line, -1 line 0 comments Download
M src/core/SkTLS.cpp View 1 chunk +1 line, -1 line 0 comments Download
M src/core/SkTaskGroup.h View 1 chunk +1 line, -1 line 0 comments Download
M src/core/SkTraceEvent.h View 1 chunk +1 line, -1 line 0 comments Download
M src/core/SkTypefaceCache.cpp View 1 chunk +1 line, -1 line 0 comments Download
M src/image/SkImage_Base.h View 1 chunk +1 line, -1 line 0 comments Download
M src/image/SkImage_Gpu.h View 1 chunk +1 line, -1 line 0 comments Download
M src/utils/SkEventTracer.cpp View 1 chunk +1 line, -1 line 0 comments Download
M src/views/SkOSMenu.cpp View 1 chunk +1 line, -1 line 0 comments Download
M tests/AtomicTest.cpp View 1 chunk +1 line, -1 line 0 comments Download
M tests/skia_test.cpp View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 6 (2 generated)
herb_g
5 years, 2 months ago (2015-09-28 18:17:21 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1369333004/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1369333004/1
5 years, 2 months ago (2015-09-28 18:17:54 UTC) #4
commit-bot: I haz the power
Committed patchset #1 (id:1) as https://skia.googlesource.com/skia/+/e6e41a8a19976a822de36379db23184ff2f28601
5 years, 2 months ago (2015-09-28 18:24:16 UTC) #5
mtklein
5 years, 2 months ago (2015-09-28 18:49:47 UTC) #6
Message was sent while issue was closed. 
lgtm

(Typically we do #include "../private/Header.h" from include/ and just #include
"Header.h" from src/, but blinding doing "../private/Header.h" should work fine
as long as some path under include/ is on the include path.)

Powered by Google App Engine
This is Rietveld 408576698