Wrap JSFunction bindings in a helper object

Wrap JSFunction bindings in a helper object.

We need to do other things with this bindings object, like store a feedback vector. Therefore, it's a good time to wrap it up in a helper class.

BUG=

Committed: https://crrev.com/5becebee313bb159e11f92535303db1332f9daec
Cr-Commit-Position: refs/heads/master@{#31044}

[mvstanton, 2015-09-30 14:48:48]

mvstanton@chromium.org changed reviewers:
+ ishell@google.com

[mvstanton, 2015-09-30 14:49:03]

mvstanton@chromium.org changed reviewers:
+ ishell@chromium.org
- ishell@google.com

[mvstanton, 2015-09-30 14:49:22]

Hi Igor,
Here is the CL we discussed, thanks for the look!
--Michael

[Igor Sheludko, 2015-10-01 08:03:36]

lgtm with nits:

https://codereview.chromium.org/1369293003/diff/60001/src/runtime/runtime-fun...
File src/runtime/runtime-function.cc (right):

https://codereview.chromium.org/1369293003/diff/60001/src/runtime/runtime-fun...
src/runtime/runtime-function.cc:360: CONVERT_ARG_HANDLE_CHECKED(Object, bindee,
1);
While you are here: it looks like bindee must be a JSReceiver, why not just
declare it as JSReceiver to avoid handle castings below.

https://codereview.chromium.org/1369293003/diff/60001/src/runtime/runtime-fun...
src/runtime/runtime-function.cc:382: int i;
Suggestion for better readability: int out_index = 0;

https://codereview.chromium.org/1369293003/diff/60001/src/runtime/runtime-fun...
src/runtime/runtime-function.cc:389: bindee =
Handle<JSReceiver>(old_bindings->bound_function(), isolate);
nit: bindee = handle(old_bindings->bound_function(), isolate);

https://codereview.chromium.org/1369293003/diff/60001/src/runtime/runtime-fun...
src/runtime/runtime-function.cc:390: Handle<Object> old_bound_this =
handle(old_bindings->bound_this(), isolate);
nit: Handle<Object> old_bound_this(old_bindings->bound_this(), isolate);

https://codereview.chromium.org/1369293003/diff/60001/src/runtime/runtime-fun...
src/runtime/runtime-function.cc:394: i = 0;
Can be removed.

https://codereview.chromium.org/1369293003/diff/60001/src/runtime/runtime-fun...
src/runtime/runtime-function.cc:396: new_bindings->set_binding(i,
old_bindings->binding(i));
suggestion: new_bindings->set_binding(out_index, old_bindings->binding(i));

https://codereview.chromium.org/1369293003/diff/60001/src/runtime/runtime-fun...
src/runtime/runtime-function.cc:401: i = 0;
Can be removed.

https://codereview.chromium.org/1369293003/diff/60001/src/runtime/runtime-fun...
src/runtime/runtime-function.cc:478: param_data[i] =
Handle<Object>(bound_args->binding(i), isolate);
nit: param_data[i] = handle(bound_args->binding(i), isolate);

[mvstanton, 2015-10-01 11:22:45]

The CQ bit was checked by mvstanton@chromium.org

[mvstanton, 2015-10-01 11:22:46]

The patchset sent to the CQ was uploaded after l-g-t-m from ishell@chromium.org
Link to the patchset: https://codereview.chromium.org/1369293003/#ps80001
(title: "comments.")

[commit-bot: I haz the power, 2015-10-01 11:22:59]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1369293003/80001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1369293003/80001

[mvstanton, 2015-10-01 11:23:01]

Thanks!

https://codereview.chromium.org/1369293003/diff/60001/src/runtime/runtime-fun...
File src/runtime/runtime-function.cc (right):

https://codereview.chromium.org/1369293003/diff/60001/src/runtime/runtime-fun...
src/runtime/runtime-function.cc:360: CONVERT_ARG_HANDLE_CHECKED(Object, bindee,
1);
On 2015/10/01 08:03:35, Igor Sheludko wrote:
> While you are here: it looks like bindee must be a JSReceiver, why not just
> declare it as JSReceiver to avoid handle castings below.

Good idea, done.

https://codereview.chromium.org/1369293003/diff/60001/src/runtime/runtime-fun...
src/runtime/runtime-function.cc:382: int i;
On 2015/10/01 08:03:35, Igor Sheludko wrote:
> Suggestion for better readability: int out_index = 0;

Done.

https://codereview.chromium.org/1369293003/diff/60001/src/runtime/runtime-fun...
src/runtime/runtime-function.cc:389: bindee =
Handle<JSReceiver>(old_bindings->bound_function(), isolate);
On 2015/10/01 08:03:35, Igor Sheludko wrote:
> nit: bindee = handle(old_bindings->bound_function(), isolate);

Done.

https://codereview.chromium.org/1369293003/diff/60001/src/runtime/runtime-fun...
src/runtime/runtime-function.cc:390: Handle<Object> old_bound_this =
handle(old_bindings->bound_this(), isolate);
On 2015/10/01 08:03:35, Igor Sheludko wrote:
> nit: Handle<Object> old_bound_this(old_bindings->bound_this(), isolate);

Done.

https://codereview.chromium.org/1369293003/diff/60001/src/runtime/runtime-fun...
src/runtime/runtime-function.cc:394: i = 0;
On 2015/10/01 08:03:35, Igor Sheludko wrote:
> Can be removed.

Done.

https://codereview.chromium.org/1369293003/diff/60001/src/runtime/runtime-fun...
src/runtime/runtime-function.cc:396: new_bindings->set_binding(i,
old_bindings->binding(i));
On 2015/10/01 08:03:35, Igor Sheludko wrote:
> suggestion: new_bindings->set_binding(out_index, old_bindings->binding(i));

Done.

https://codereview.chromium.org/1369293003/diff/60001/src/runtime/runtime-fun...
src/runtime/runtime-function.cc:401: i = 0;
On 2015/10/01 08:03:35, Igor Sheludko wrote:
> Can be removed.

Done.

https://codereview.chromium.org/1369293003/diff/60001/src/runtime/runtime-fun...
src/runtime/runtime-function.cc:478: param_data[i] =
Handle<Object>(bound_args->binding(i), isolate);
On 2015/10/01 08:03:35, Igor Sheludko wrote:
> nit: param_data[i] = handle(bound_args->binding(i), isolate);

Done.

[commit-bot: I haz the power, 2015-10-01 11:45:54]

Committed patchset #5 (id:80001)

[commit-bot: I haz the power, 2015-10-01 11:46:29]

Patchset 5 (id:??) landed as
https://crrev.com/5becebee313bb159e11f92535303db1332f9daec
Cr-Commit-Position: refs/heads/master@{#31044}